[GitHub] [pulsar] srkukarni commented on a change in pull request #4222: Add helper method to for IO connectors to use function secrets

[GitBox <gi...@apache.org>]

srkukarni commented on a change in pull request #4222: Add helper method to for IO connectors to use function secrets
URL: https://github.com/apache/pulsar/pull/4222#discussion_r281402835
 
 

 ##########
 File path: pulsar-io/twitter/src/main/java/org/apache/pulsar/io/twitter/TwitterFireHose.java
 ##########
 @@ -71,7 +72,7 @@
 
     @Override
     public void open(Map<String, Object> config, SourceContext sourceContext) throws IOException {
-        TwitterFireHoseConfig hoseConfig = TwitterFireHoseConfig.load(config);
+        TwitterFireHoseConfig hoseConfig = IOConfigUtils.loadWithSecrets(config, TwitterFireHoseConfig.class, sourceContext);
 
 Review comment:
   should this be gated with a config parameter? What if I'm just running a simple connector like twitter on my laptop without having any need for secrets?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services