You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Gabriel39 (via GitHub)" <gi...@apache.org> on 2024/06/06 07:40:03 UTC
[PR] [fix](pipeline) Do not push data in local exchange if eos [doris]
Gabriel39 opened a new pull request, #35972:
URL: https://github.com/apache/doris/pull/35972
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](pipeline) Do not push data in local exchange if eos [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #35972:
URL: https://github.com/apache/doris/pull/35972#discussion_r1628942221
##########
be/src/pipeline/local_exchange/local_exchanger.h:
##########
@@ -68,6 +69,56 @@
moodycamel::ConcurrentQueue<vectorized::Block> _free_blocks;
};
+struct PartitionedRowIdxs {
+ std::shared_ptr<vectorized::PODArray<uint32_t>> row_idxs;
+ uint32_t offset_start;
+ uint32_t length;
+};
+
+using PartitionedBlock = std::pair<std::shared_ptr<ShuffleBlockWrapper>, PartitionedRowIdxs>;
+
+template <typename BlockType>
+struct BlockQueue {
+ std::atomic<bool> eos = false;
+ moodycamel::ConcurrentQueue<BlockType> data_queue;
+ BlockQueue() : eos(false), data_queue(moodycamel::ConcurrentQueue<BlockType>()) {}
+ BlockQueue(BlockQueue<BlockType>&& other)
+ : eos(other.eos.load()), data_queue(std::move(other.data_queue)) {}
+ inline bool enqueue(BlockType const& item) {
+ if (!eos) {
+ data_queue.enqueue(item);
+ return true;
Review Comment:
warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
be/src/pipeline/local_exchange/local_exchanger.h:87:
```diff
- if (!eos) {
- data_queue.enqueue(item);
- return true;
- }
- return false;
+ return !eos;
```
##########
be/src/pipeline/local_exchange/local_exchanger.h:
##########
@@ -68,6 +69,56 @@ class Exchanger {
moodycamel::ConcurrentQueue<vectorized::Block> _free_blocks;
};
+struct PartitionedRowIdxs {
+ std::shared_ptr<vectorized::PODArray<uint32_t>> row_idxs;
+ uint32_t offset_start;
+ uint32_t length;
+};
+
+using PartitionedBlock = std::pair<std::shared_ptr<ShuffleBlockWrapper>, PartitionedRowIdxs>;
+
+template <typename BlockType>
+struct BlockQueue {
+ std::atomic<bool> eos = false;
+ moodycamel::ConcurrentQueue<BlockType> data_queue;
+ BlockQueue() : eos(false), data_queue(moodycamel::ConcurrentQueue<BlockType>()) {}
Review Comment:
warning: use '= default' to define a trivial default constructor [modernize-use-equals-default]
```suggestion
BlockQueue() : eos(false), data_queue(moodycamel::ConcurrentQueue<BlockType>()) = default;
```
##########
be/src/pipeline/local_exchange/local_exchanger.h:
##########
@@ -68,6 +69,56 @@
moodycamel::ConcurrentQueue<vectorized::Block> _free_blocks;
};
+struct PartitionedRowIdxs {
+ std::shared_ptr<vectorized::PODArray<uint32_t>> row_idxs;
+ uint32_t offset_start;
+ uint32_t length;
+};
+
+using PartitionedBlock = std::pair<std::shared_ptr<ShuffleBlockWrapper>, PartitionedRowIdxs>;
+
+template <typename BlockType>
+struct BlockQueue {
+ std::atomic<bool> eos = false;
+ moodycamel::ConcurrentQueue<BlockType> data_queue;
+ BlockQueue() : eos(false), data_queue(moodycamel::ConcurrentQueue<BlockType>()) {}
+ BlockQueue(BlockQueue<BlockType>&& other)
+ : eos(other.eos.load()), data_queue(std::move(other.data_queue)) {}
+ inline bool enqueue(BlockType const& item) {
+ if (!eos) {
+ data_queue.enqueue(item);
+ return true;
+ }
+ return false;
+ }
+
+ inline bool enqueue(BlockType&& item) {
+ if (!eos) {
+ data_queue.enqueue(item);
+ return true;
Review Comment:
warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
be/src/pipeline/local_exchange/local_exchanger.h:95:
```diff
- if (!eos) {
- data_queue.enqueue(item);
- return true;
- }
- return false;
+ return !eos;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](pipeline) Do not push data in local exchange if eos [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #35972:
URL: https://github.com/apache/doris/pull/35972#discussion_r1629130090
##########
be/src/pipeline/local_exchange/local_exchanger.h:
##########
@@ -68,6 +69,56 @@ class Exchanger {
moodycamel::ConcurrentQueue<vectorized::Block> _free_blocks;
};
+struct PartitionedRowIdxs {
+ std::shared_ptr<vectorized::PODArray<uint32_t>> row_idxs;
+ uint32_t offset_start;
+ uint32_t length;
+};
+
+using PartitionedBlock = std::pair<std::shared_ptr<ShuffleBlockWrapper>, PartitionedRowIdxs>;
+
+template <typename BlockType>
+struct BlockQueue {
+ std::atomic<bool> eos = false;
+ moodycamel::ConcurrentQueue<BlockType> data_queue;
+ BlockQueue() : eos(false), data_queue(moodycamel::ConcurrentQueue<BlockType>()) {}
+ BlockQueue(BlockQueue<BlockType>&& other)
+ : eos(other.eos.load()), data_queue(std::move(other.data_queue)) {}
+ inline bool enqueue(BlockType const& item) {
+ if (!eos) {
+ data_queue.enqueue(item);
+ return true;
+ }
+ return false;
+ }
+
+ inline bool enqueue(BlockType&& item) {
+ if (!eos) {
+ data_queue.enqueue(std::move(item));
+ return true;
Review Comment:
warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
be/src/pipeline/local_exchange/local_exchanger.h:95:
```diff
- if (!eos) {
- data_queue.enqueue(std::move(item));
- return true;
- }
- return false;
+ return !eos;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](pipeline) Do not push data in local exchange if eos [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35972:
URL: https://github.com/apache/doris/pull/35972#issuecomment-2152654167
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](pipeline) Do not push data in local exchange if eos [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #35972:
URL: https://github.com/apache/doris/pull/35972#issuecomment-2152030366
TeamCity be ut coverage result:
Function Coverage: 36.43% (8973/24628)
Line Coverage: 27.96% (73305/262140)
Region Coverage: 27.37% (37999/138858)
Branch Coverage: 23.98% (19290/80444)
Coverage Report: http://coverage.selectdb-in.cc/coverage/aaf5d80decedf661eb2385062838151e83460ff9_aaf5d80decedf661eb2385062838151e83460ff9/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](pipeline) Do not push data in local exchange if eos [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 merged PR #35972:
URL: https://github.com/apache/doris/pull/35972
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](pipeline) Do not push data in local exchange if eos [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #35972:
URL: https://github.com/apache/doris/pull/35972#issuecomment-2151819493
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](pipeline) Do not push data in local exchange if eos [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #35972:
URL: https://github.com/apache/doris/pull/35972#issuecomment-2151609564
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](pipeline) Do not push data in local exchange if eos [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #35972:
URL: https://github.com/apache/doris/pull/35972#issuecomment-2152015364
<details>
<summary>ClickBench: <b>Total hot run time: 30.92 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit aaf5d80decedf661eb2385062838151e83460ff9, data reload: false
query1 0.04 0.03 0.03
query2 0.08 0.04 0.05
query3 0.24 0.06 0.06
query4 1.67 0.09 0.10
query5 0.51 0.47 0.51
query6 1.13 0.73 0.72
query7 0.02 0.02 0.02
query8 0.05 0.04 0.04
query9 0.54 0.49 0.48
query10 0.55 0.56 0.55
query11 0.16 0.12 0.11
query12 0.16 0.12 0.12
query13 0.61 0.58 0.59
query14 0.78 0.80 0.77
query15 0.84 0.81 0.84
query16 0.35 0.35 0.36
query17 1.00 0.98 0.98
query18 0.20 0.27 0.23
query19 1.85 1.70 1.83
query20 0.02 0.01 0.01
query21 15.60 0.67 0.66
query22 3.55 7.35 2.32
query23 18.29 1.40 1.32
query24 2.15 0.22 0.20
query25 0.16 0.09 0.09
query26 0.26 0.17 0.18
query27 0.07 0.07 0.09
query28 13.23 1.01 0.99
query29 13.25 3.30 3.28
query30 0.24 0.06 0.07
query31 2.86 0.40 0.37
query32 3.28 0.46 0.47
query33 2.89 2.87 2.93
query34 17.04 4.39 4.42
query35 4.51 4.46 4.53
query36 0.65 0.46 0.46
query37 0.18 0.15 0.16
query38 0.15 0.14 0.15
query39 0.04 0.04 0.04
query40 0.17 0.14 0.14
query41 0.08 0.04 0.04
query42 0.05 0.05 0.05
query43 0.03 0.03 0.04
Total cold run time: 109.53 s
Total hot run time: 30.92 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](pipeline) Do not push data in local exchange if eos [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #35972:
URL: https://github.com/apache/doris/pull/35972#issuecomment-2151713321
TeamCity be ut coverage result:
Function Coverage: 36.36% (8989/24723)
Line Coverage: 27.91% (73410/263045)
Region Coverage: 27.33% (37995/139012)
Branch Coverage: 23.94% (19279/80544)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3b87958551be1980765e7e7319ae21fb1f621862_3b87958551be1980765e7e7319ae21fb1f621862/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](pipeline) Do not push data in local exchange if eos [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35972:
URL: https://github.com/apache/doris/pull/35972#issuecomment-2152654237
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](pipeline) Do not push data in local exchange if eos [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #35972:
URL: https://github.com/apache/doris/pull/35972#issuecomment-2151724382
<details>
<summary>TPC-DS: <b>Total hot run time: 171706 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3b87958551be1980765e7e7319ae21fb1f621862, data reload: false
query1 930 379 370 370
query2 6452 2529 2434 2434
query3 6651 218 217 217
query4 19449 17540 17132 17132
query5 4127 466 474 466
query6 242 160 158 158
query7 4590 314 298 298
query8 313 284 294 284
query9 8717 2424 2401 2401
query10 431 296 265 265
query11 10545 10005 10007 10005
query12 139 81 82 81
query13 1624 372 360 360
query14 10235 6571 7029 6571
query15 225 188 188 188
query16 7267 264 260 260
query17 1353 541 531 531
query18 1823 302 268 268
query19 192 152 147 147
query20 86 81 79 79
query21 209 125 128 125
query22 4445 4220 4088 4088
query23 33665 32869 33018 32869
query24 12433 2821 2800 2800
query25 686 353 355 353
query26 1814 156 154 154
query27 2998 320 318 318
query28 7711 2039 2039 2039
query29 1254 612 591 591
query30 278 152 149 149
query31 944 722 742 722
query32 96 54 56 54
query33 760 285 299 285
query34 973 477 474 474
query35 727 617 614 614
query36 1068 923 923 923
query37 282 68 70 68
query38 2835 2752 2740 2740
query39 854 788 788 788
query40 285 127 118 118
query41 55 53 51 51
query42 114 97 96 96
query43 596 539 529 529
query44 1190 723 744 723
query45 194 169 164 164
query46 1065 722 719 719
query47 1827 1779 1784 1779
query48 366 303 303 303
query49 1186 407 415 407
query50 793 391 378 378
query51 6827 6667 6576 6576
query52 130 93 90 90
query53 358 284 287 284
query54 1030 447 439 439
query55 75 75 74 74
query56 278 264 259 259
query57 1133 1084 1060 1060
query58 256 237 258 237
query59 3401 3226 3383 3226
query60 288 255 265 255
query61 88 86 84 84
query62 665 439 434 434
query63 327 300 296 296
query64 10033 2213 1717 1717
query65 3159 3113 3138 3113
query66 1412 335 337 335
query67 15508 15007 14868 14868
query68 4498 554 545 545
query69 451 313 304 304
query70 1187 1077 1117 1077
query71 430 272 268 268
query72 6995 5288 5512 5288
query73 759 326 328 326
query74 5969 5453 5519 5453
query75 3326 2715 2636 2636
query76 2390 1023 903 903
query77 433 298 290 290
query78 10172 9877 9717 9717
query79 1689 516 524 516
query80 2298 461 455 455
query81 590 217 227 217
query82 1048 101 99 99
query83 301 172 166 166
query84 258 83 96 83
query85 1272 318 323 318
query86 390 300 313 300
query87 3306 3121 3093 3093
query88 3067 2362 2352 2352
query89 496 396 388 388
query90 1756 186 186 186
query91 125 98 97 97
query92 59 47 49 47
query93 1564 508 506 506
query94 1237 181 183 181
query95 402 315 315 315
query96 591 282 270 270
query97 3204 3015 3053 3015
query98 229 198 192 192
query99 1223 837 820 820
Total cold run time: 273777 ms
Total hot run time: 171706 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](pipeline) Do not push data in local exchange if eos [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #35972:
URL: https://github.com/apache/doris/pull/35972#issuecomment-2151737983
<details>
<summary>ClickBench: <b>Total hot run time: 30.91 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3b87958551be1980765e7e7319ae21fb1f621862, data reload: false
query1 0.04 0.03 0.03
query2 0.07 0.04 0.04
query3 0.22 0.06 0.05
query4 1.67 0.10 0.09
query5 0.49 0.49 0.50
query6 1.13 0.72 0.73
query7 0.01 0.01 0.02
query8 0.05 0.04 0.04
query9 0.54 0.49 0.51
query10 0.56 0.56 0.53
query11 0.15 0.11 0.11
query12 0.14 0.11 0.11
query13 0.60 0.59 0.61
query14 0.77 0.79 0.78
query15 0.85 0.82 0.81
query16 0.37 0.37 0.36
query17 0.98 1.05 1.04
query18 0.20 0.28 0.20
query19 1.89 1.84 1.74
query20 0.01 0.01 0.02
query21 15.71 0.67 0.66
query22 4.19 7.32 2.11
query23 18.31 1.37 1.37
query24 2.14 0.22 0.21
query25 0.16 0.09 0.08
query26 0.26 0.17 0.18
query27 0.08 0.08 0.08
query28 13.29 1.03 1.00
query29 13.23 3.30 3.31
query30 0.24 0.06 0.05
query31 2.88 0.38 0.38
query32 3.25 0.48 0.48
query33 2.89 2.89 2.96
query34 17.02 4.34 4.41
query35 4.48 4.53 4.49
query36 0.65 0.48 0.47
query37 0.17 0.15 0.16
query38 0.15 0.14 0.14
query39 0.05 0.03 0.03
query40 0.17 0.14 0.15
query41 0.09 0.04 0.05
query42 0.05 0.05 0.05
query43 0.04 0.04 0.04
Total cold run time: 110.24 s
Total hot run time: 30.91 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](pipeline) Do not push data in local exchange if eos [doris]
Posted by "Gabriel39 (via GitHub)" <gi...@apache.org>.
Gabriel39 commented on PR #35972:
URL: https://github.com/apache/doris/pull/35972#issuecomment-2151618478
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](pipeline) Do not push data in local exchange if eos [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #35972:
URL: https://github.com/apache/doris/pull/35972#issuecomment-2151703822
<details>
<summary>TPC-H: <b>Total hot run time: 40209 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3b87958551be1980765e7e7319ae21fb1f621862, data reload: false
------ Round 1 ----------------------------------
q1 18264 4583 4393 4393
q2 2578 202 199 199
q3 11364 1135 1152 1135
q4 10510 824 914 824
q5 7874 2762 2677 2677
q6 223 138 138 138
q7 966 621 613 613
q8 9560 2101 2075 2075
q9 9049 6520 6498 6498
q10 8998 3736 3716 3716
q11 459 248 235 235
q12 420 232 226 226
q13 17758 2986 2993 2986
q14 262 223 220 220
q15 527 485 481 481
q16 541 386 378 378
q17 962 658 694 658
q18 8123 7605 7514 7514
q19 3209 1594 1452 1452
q20 682 303 319 303
q21 4916 3150 3909 3150
q22 397 349 338 338
Total cold run time: 117642 ms
Total hot run time: 40209 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4375 4289 4244 4244
q2 365 277 268 268
q3 2984 2755 2688 2688
q4 1874 1643 1628 1628
q5 5257 5307 5306 5306
q6 217 127 128 127
q7 2182 1732 1760 1732
q8 3219 3331 3331 3331
q9 8416 8394 8386 8386
q10 3913 3657 3667 3657
q11 582 498 484 484
q12 765 604 640 604
q13 17326 3003 3004 3003
q14 298 275 257 257
q15 518 486 488 486
q16 482 415 402 402
q17 1808 1503 1464 1464
q18 7656 7558 7466 7466
q19 1884 1587 1650 1587
q20 1972 1777 1772 1772
q21 4792 4758 4555 4555
q22 600 533 527 527
Total cold run time: 71485 ms
Total hot run time: 53974 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](pipeline) Do not push data in local exchange if eos [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #35972:
URL: https://github.com/apache/doris/pull/35972#issuecomment-2151960540
<details>
<summary>TPC-H: <b>Total hot run time: 40409 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit aaf5d80decedf661eb2385062838151e83460ff9, data reload: false
------ Round 1 ----------------------------------
q1 18402 4646 4425 4425
q2 2683 207 205 205
q3 11161 1136 1249 1136
q4 10239 801 818 801
q5 7556 2796 2718 2718
q6 231 134 140 134
q7 978 624 613 613
q8 9390 2094 2116 2094
q9 8975 6526 6518 6518
q10 8923 3707 3721 3707
q11 462 247 238 238
q12 408 237 232 232
q13 17792 3063 2996 2996
q14 264 219 234 219
q15 525 469 472 469
q16 515 402 391 391
q17 988 655 770 655
q18 8029 7457 7499 7457
q19 7366 1542 1458 1458
q20 662 314 304 304
q21 4951 3889 3303 3303
q22 402 338 336 336
Total cold run time: 120902 ms
Total hot run time: 40409 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4372 4243 4262 4243
q2 384 272 273 272
q3 3000 2774 2709 2709
q4 1856 1649 1665 1649
q5 5327 5323 5322 5322
q6 219 126 128 126
q7 2136 1713 1719 1713
q8 3220 3354 3338 3338
q9 8326 8326 8400 8326
q10 3890 3645 3685 3645
q11 596 503 502 502
q12 767 601 602 601
q13 17469 2984 3013 2984
q14 299 275 262 262
q15 518 471 480 471
q16 477 407 419 407
q17 1833 1526 1475 1475
q18 7665 7453 7450 7450
q19 1696 1669 1692 1669
q20 1972 1813 1772 1772
q21 5027 4690 4799 4690
q22 638 549 551 549
Total cold run time: 71687 ms
Total hot run time: 54175 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](pipeline) Do not push data in local exchange if eos [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #35972:
URL: https://github.com/apache/doris/pull/35972#issuecomment-2151997461
<details>
<summary>TPC-DS: <b>Total hot run time: 173145 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit aaf5d80decedf661eb2385062838151e83460ff9, data reload: false
query1 923 381 367 367
query2 6460 2408 2397 2397
query3 6659 210 211 210
query4 19961 17456 17398 17398
query5 4144 467 473 467
query6 252 160 162 160
query7 4597 300 304 300
query8 337 301 285 285
query9 8466 2420 2375 2375
query10 441 301 281 281
query11 10478 10024 9982 9982
query12 135 93 86 86
query13 1632 361 374 361
query14 9588 7050 7071 7050
query15 228 192 183 183
query16 7761 271 263 263
query17 1490 548 514 514
query18 1772 276 280 276
query19 198 158 158 158
query20 91 86 81 81
query21 207 138 130 130
query22 4175 4100 3964 3964
query23 33726 33088 33096 33088
query24 12033 2833 2888 2833
query25 664 359 361 359
query26 1783 162 159 159
query27 2995 317 321 317
query28 7397 2048 2043 2043
query29 1140 631 621 621
query30 282 148 151 148
query31 971 751 747 747
query32 93 58 56 56
query33 794 294 273 273
query34 989 488 487 487
query35 773 615 601 601
query36 1109 950 965 950
query37 208 73 76 73
query38 2887 2724 2738 2724
query39 886 814 803 803
query40 285 132 133 132
query41 61 56 54 54
query42 118 101 103 101
query43 598 549 567 549
query44 1208 739 743 739
query45 200 168 169 168
query46 1086 772 736 736
query47 1861 1765 1765 1765
query48 397 307 301 301
query49 1191 447 445 445
query50 791 396 404 396
query51 6716 6751 6633 6633
query52 111 93 97 93
query53 371 296 293 293
query54 1006 455 458 455
query55 77 77 77 77
query56 315 281 301 281
query57 1185 1037 1063 1037
query58 279 267 295 267
query59 3543 3122 3058 3058
query60 325 305 292 292
query61 108 107 111 107
query62 651 461 436 436
query63 327 302 306 302
query64 9950 2395 1813 1813
query65 3276 3127 3148 3127
query66 1365 352 336 336
query67 15373 14855 15050 14855
query68 4727 572 561 561
query69 636 438 388 388
query70 1211 1136 1130 1130
query71 459 288 283 283
query72 9022 5520 5636 5520
query73 770 334 329 329
query74 5909 5438 5500 5438
query75 4094 2697 2690 2690
query76 3153 954 901 901
query77 701 315 297 297
query78 10410 9833 9705 9705
query79 4818 521 524 521
query80 2749 455 461 455
query81 581 224 219 219
query82 836 105 101 101
query83 328 170 174 170
query84 267 88 86 86
query85 2201 268 262 262
query86 511 328 319 319
query87 3255 3054 3086 3054
query88 4725 2350 2345 2345
query89 511 386 389 386
query90 1891 183 188 183
query91 128 95 96 95
query92 67 49 49 49
query93 5555 526 495 495
query94 1315 201 181 181
query95 431 315 328 315
query96 586 270 263 263
query97 3197 2951 2991 2951
query98 221 204 195 195
query99 1202 846 840 840
Total cold run time: 287966 ms
Total hot run time: 173145 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org