You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2022/09/18 23:24:49 UTC

[Impala-ASF-CR](branch-4.1.1) IMPALA-11557: Fix memory leak in BlockingRowBatchQueue

Hello Impala Public Jenkins,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/19007

to review the following change.


Change subject: IMPALA-11557: Fix memory leak in BlockingRowBatchQueue
......................................................................

IMPALA-11557: Fix memory leak in BlockingRowBatchQueue

'batch_queue_' is a pointer to store the RowBatches. It's
initialized in the constructor but not deleted in the destructor.

The way to fix in the patch is to use std::unique_ptr.

Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56
Reviewed-on: http://gerrit.cloudera.org:8080/18960
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Quanlong Huang <hu...@gmail.com>
---
M be/src/runtime/blocking-row-batch-queue.h
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/19007/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19007
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: newchange
Gerrit-Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56
Gerrit-Change-Number: 19007
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Xianqing He <he...@126.com>

[Impala-ASF-CR](branch-4.1.1) IMPALA-11557: Fix memory leak in BlockingRowBatchQueue

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19007 )

Change subject: IMPALA-11557: Fix memory leak in BlockingRowBatchQueue
......................................................................


Patch Set 1: Verified+1

Verified by https://jenkins.impala.io/job/gerrit-verify-dryrun/8591/


-- 
To view, visit http://gerrit.cloudera.org:8080/19007
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: comment
Gerrit-Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56
Gerrit-Change-Number: 19007
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xianqing He <he...@126.com>
Gerrit-Comment-Date: Tue, 20 Sep 2022 05:16:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR](branch-4.1.1) IMPALA-11557: Fix memory leak in BlockingRowBatchQueue

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/19007 )

Change subject: IMPALA-11557: Fix memory leak in BlockingRowBatchQueue
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/19007
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: comment
Gerrit-Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56
Gerrit-Change-Number: 19007
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xianqing He <he...@126.com>
Gerrit-Comment-Date: Mon, 19 Sep 2022 05:41:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR](branch-4.1.1) IMPALA-11557: Fix memory leak in BlockingRowBatchQueue

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19007 )

Change subject: IMPALA-11557: Fix memory leak in BlockingRowBatchQueue
......................................................................

IMPALA-11557: Fix memory leak in BlockingRowBatchQueue

'batch_queue_' is a pointer to store the RowBatches. It's
initialized in the constructor but not deleted in the destructor.

The way to fix in the patch is to use std::unique_ptr.

Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56
Reviewed-on: http://gerrit.cloudera.org:8080/18960
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Quanlong Huang <hu...@gmail.com>
Reviewed-on: http://gerrit.cloudera.org:8080/19007
Reviewed-by: Csaba Ringhofer <cs...@cloudera.com>
---
M be/src/runtime/blocking-row-batch-queue.h
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Csaba Ringhofer: Looks good to me, approved
  Quanlong Huang: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/19007
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: merged
Gerrit-Change-Id: I656316b6575ce74a03b83fcd45e772c763835d56
Gerrit-Change-Number: 19007
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Xianqing He <he...@126.com>