[GitHub] [flink] wuchong edited a comment on issue #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC

[GitBox <gi...@apache.org>]

wuchong edited a comment on issue #8867: [FLINK-12956][jdbc] Introduce upsert table sink for JDBC
URL: https://github.com/apache/flink/pull/8867#issuecomment-507110081
 
 
   > 1.The only difference between databases is just quoteIdentifier and the upsert mechanism now.
   
   Maybe we will encounter the same data type problem with spark. And maybe will add `getJDBCType` in the future.
   
   > whether the implementation of each database requires relevant parameters and whether the order of parameters is the same.
   
   Yes, this is a problem. However, I have looked into upsert statements in several databases (mysql, postgres, sqlserver) and they requires the same parameters and the order is the same.
   
   > And I think JdbcDialect is an interface to users, it should be simpler. We should expose it because 
   
   There are so many different upsert mechanisms that we don't support.
   Why we should expose `JdbcDialect` to users? IMO, this is an internal interface to handle different databases (well-know databases). 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services