You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/02/17 12:33:47 UTC

[GitHub] [maven-resolver] cstamas commented on a change in pull request #144: Use BFS approach

cstamas commented on a change in pull request #144:
URL: https://github.com/apache/maven-resolver/pull/144#discussion_r809000303



##########
File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DefaultDependencyCollector.java
##########
@@ -744,7 +734,7 @@ private static boolean isLackingDescriptor( Artifact artifact )
             maxCycles = ConfigUtils.getInteger( session, CONFIG_PROP_MAX_CYCLES_DEFAULT, CONFIG_PROP_MAX_CYCLES );
         }
 
-        public void addException( Dependency dependency, Exception e, NodeStack nodes )
+        public void addException( Dependency dependency, Exception e, List<DependencyNode> nodes )

Review comment:
       The new type of `nodes` now allows enhanced `for` below, no need for `int i`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org