You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2021/02/03 10:33:20 UTC
[GitHub] [kylin] tianhui5 opened a new pull request #1568: KYLIN-4895: change spark deploy mode of kylin4.0 engine from local to cluster
tianhui5 opened a new pull request #1568:
URL: https://github.com/apache/kylin/pull/1568
## Proposed changes
JIRA: https://issues.apache.org/jira/browse/KYLIN-4895
## Types of changes
- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have create an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
- [ ] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If this change need a document change, I will prepare another pr against the `document` branch
- [ ] Any dependent changes have been merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] tianhui5 commented on a change in pull request #1568: KYLIN-4895: change spark deploy mode of kylin4.0 engine from local to cluster
Posted by GitBox <gi...@apache.org>.
tianhui5 commented on a change in pull request #1568:
URL: https://github.com/apache/kylin/pull/1568#discussion_r655118840
##########
File path: kylin-spark-project/kylin-spark-engine/src/main/java/org/apache/kylin/engine/spark/job/NSparkExecutable.java
##########
@@ -382,6 +387,8 @@ protected String generateSparkCmd(KylinConfig config, String hadoopConf, String
if (StringUtils.isNotBlank(sparkUploadFiles)) {
sb.append("--files ").append(sparkUploadFiles).append(" ");
}
+ sb.append("--principal ").append(config.getKerberosPrincipal()).append(" ");
+ sb.append("--keytab ").append(config.getKerberosKeytabPath()).append(" ");
Review comment:
My mistake, I'll add Kerberos usage check right here, but not in java options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] zzcclp commented on a change in pull request #1568: KYLIN-4895: change spark deploy mode of kylin4.0 engine from local to cluster
Posted by GitBox <gi...@apache.org>.
zzcclp commented on a change in pull request #1568:
URL: https://github.com/apache/kylin/pull/1568#discussion_r655075865
##########
File path: kylin-spark-project/kylin-spark-engine/src/main/java/org/apache/kylin/engine/spark/job/NSparkExecutable.java
##########
@@ -382,6 +387,8 @@ protected String generateSparkCmd(KylinConfig config, String hadoopConf, String
if (StringUtils.isNotBlank(sparkUploadFiles)) {
sb.append("--files ").append(sparkUploadFiles).append(" ");
}
+ sb.append("--principal ").append(config.getKerberosPrincipal()).append(" ");
+ sb.append("--keytab ").append(config.getKerberosKeytabPath()).append(" ");
Review comment:
why it needs these two lines directly ? please check the code in the method 'replaceSparkNodeJavaOpsConfIfNeeded', it will set the parameters about kerberos according to 'config.isKerberosEnabled()'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] codecov-commenter commented on pull request #1568: KYLIN-4895: change spark deploy mode of kylin4.0 engine from local to cluster
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1568:
URL: https://github.com/apache/kylin/pull/1568#issuecomment-864712270
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1568?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`kylin-on-parquet-v2@c943745`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/kylin/pull/1568?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## kylin-on-parquet-v2 #1568 +/- ##
======================================================
Coverage ? 24.01%
Complexity ? 4649
======================================================
Files ? 1158
Lines ? 66424
Branches ? 9735
======================================================
Hits ? 15951
Misses ? 48795
Partials ? 1678
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1568?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1568?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c943745...0f6456c](https://codecov.io/gh/apache/kylin/pull/1568?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] zhangayqian commented on pull request #1568: KYLIN-4895: change spark deploy mode of kylin4.0 engine from local to cluster
Posted by GitBox <gi...@apache.org>.
zhangayqian commented on pull request #1568:
URL: https://github.com/apache/kylin/pull/1568#issuecomment-863869542
When testing this patch, I encountered the following error in the first step of the build job:
<img width="1303" alt="image" src="https://user-images.githubusercontent.com/31064237/122533007-ab50e300-d053-11eb-8192-5fdef3c699b3.png">
`Detect Resource` only support `spark.master=local`, at this time, `spark.submit.deployMode` cannot be set to `cluster`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] lgtm-com[bot] commented on pull request #1568: KYLIN-4895: change spark deploy mode of kylin4.0 engine from local to cluster
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #1568:
URL: https://github.com/apache/kylin/pull/1568#issuecomment-781958873
This pull request **introduces 2 alerts** when merging b01587624bc3edf34d19548751d5a9737ec42f2d into b428f1e1ab6a48101bec03e515d135c57af32878 - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-cd1533446511e850b609c3597a1229696d86cef7)
**new alerts:**
* 2 for Potential input resource leak
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] tianhui5 commented on a change in pull request #1568: KYLIN-4895: change spark deploy mode of kylin4.0 engine from local to cluster
Posted by GitBox <gi...@apache.org>.
tianhui5 commented on a change in pull request #1568:
URL: https://github.com/apache/kylin/pull/1568#discussion_r655118840
##########
File path: kylin-spark-project/kylin-spark-engine/src/main/java/org/apache/kylin/engine/spark/job/NSparkExecutable.java
##########
@@ -382,6 +387,8 @@ protected String generateSparkCmd(KylinConfig config, String hadoopConf, String
if (StringUtils.isNotBlank(sparkUploadFiles)) {
sb.append("--files ").append(sparkUploadFiles).append(" ");
}
+ sb.append("--principal ").append(config.getKerberosPrincipal()).append(" ");
+ sb.append("--keytab ").append(config.getKerberosKeytabPath()).append(" ");
Review comment:
My mistake, I'll add Kerberos usage check right here, but not in java options.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] zhangayqian edited a comment on pull request #1568: KYLIN-4895: change spark deploy mode of kylin4.0 engine from local to cluster
Posted by GitBox <gi...@apache.org>.
zhangayqian edited a comment on pull request #1568:
URL: https://github.com/apache/kylin/pull/1568#issuecomment-863869542
When testing this patch, I encountered the following error in the first step of the build job:
<img width="1303" alt="image" src="https://user-images.githubusercontent.com/31064237/122533007-ab50e300-d053-11eb-8192-5fdef3c699b3.png">
`Detect Resource` only support `spark.master=local`, at this time, `spark.submit.deployMode` cannot be set to `cluster`.
I tried to add `spark.submit.deployMode` to `excludedSparkConf` in class `NSparkLocalStep` and retested. Then the first step was successful.
But at `Build cube with spark` step, the following error was reported:
```
throwable : java.lang.RuntimeException: Error execute org.apache.kylin.engine.spark.job.CubeBuildJob
at org.apache.kylin.engine.spark.application.SparkApplication.execute(SparkApplication.java:101)
at org.apache.spark.application.JobWorker$$anon$2.run(JobWorker.scala:55)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.IllegalArgumentException: Can not create a Path from an empty string
at org.apache.hadoop.fs.Path.checkPathArg(Path.java:126)
at org.apache.hadoop.fs.Path.<init>(Path.java:134)
at org.apache.hadoop.fs.Path.<init>(Path.java:93)
at org.apache.spark.deploy.yarn.Client.copyFileToRemote(Client.scala:383)
at org.apache.spark.deploy.yarn.Client.org$apache$spark$deploy$yarn$Client$$distribute$1(Client.scala:477)
at org.apache.spark.deploy.yarn.Client.prepareLocalResources(Client.scala:496)
at org.apache.spark.deploy.yarn.Client.createContainerLaunchContext(Client.scala:865)
at org.apache.spark.deploy.yarn.Client.submitApplication(Client.scala:179)
at org.apache.spark.scheduler.cluster.YarnClientSchedulerBackend.start(YarnClientSchedulerBackend.scala:57)
at org.apache.spark.scheduler.TaskSchedulerImpl.start(TaskSchedulerImpl.scala:188)
at org.apache.spark.SparkContext.<init>(SparkContext.scala:501)
at org.apache.spark.SparkContext$.getOrCreate(SparkContext.scala:2520)
at org.apache.spark.sql.SparkSession$Builder$$anonfun$7.apply(SparkSession.scala:930)
at org.apache.spark.sql.SparkSession$Builder$$anonfun$7.apply(SparkSession.scala:921)
at scala.Option.getOrElse(Option.scala:121)
at org.apache.spark.sql.SparkSession$Builder.getOrCreate(SparkSession.scala:921)
at org.apache.kylin.engine.spark.application.SparkApplication.execute(SparkApplication.java:303)
at org.apache.kylin.engine.spark.application.SparkApplication.execute(SparkApplication.java:98)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] zhangayqian merged pull request #1568: KYLIN-4895: change spark deploy mode of kylin4.0 engine from local to cluster
Posted by GitBox <gi...@apache.org>.
zhangayqian merged pull request #1568:
URL: https://github.com/apache/kylin/pull/1568
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] zhangayqian commented on pull request #1568: KYLIN-4895: change spark deploy mode of kylin4.0 engine from local to cluster
Posted by GitBox <gi...@apache.org>.
zhangayqian commented on pull request #1568:
URL: https://github.com/apache/kylin/pull/1568#issuecomment-865654489
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] zzcclp commented on a change in pull request #1568: KYLIN-4895: change spark deploy mode of kylin4.0 engine from local to cluster
Posted by GitBox <gi...@apache.org>.
zzcclp commented on a change in pull request #1568:
URL: https://github.com/apache/kylin/pull/1568#discussion_r655075865
##########
File path: kylin-spark-project/kylin-spark-engine/src/main/java/org/apache/kylin/engine/spark/job/NSparkExecutable.java
##########
@@ -382,6 +387,8 @@ protected String generateSparkCmd(KylinConfig config, String hadoopConf, String
if (StringUtils.isNotBlank(sparkUploadFiles)) {
sb.append("--files ").append(sparkUploadFiles).append(" ");
}
+ sb.append("--principal ").append(config.getKerberosPrincipal()).append(" ");
+ sb.append("--keytab ").append(config.getKerberosKeytabPath()).append(" ");
Review comment:
why it needs these two lines? please check the code in the method 'replaceSparkNodeJavaOpsConfIfNeeded', it will set the parameters about kerberos according to 'config.isKerberosEnabled()'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] lgtm-com[bot] commented on pull request #1568: KYLIN-4895: change spark deploy mode of kylin4.0 engine from local to cluster
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #1568:
URL: https://github.com/apache/kylin/pull/1568#issuecomment-772439896
This pull request **introduces 2 alerts** when merging 0a29245f3439da04c9bd4441bcf5242c59e3a8a0 into b0551bef5e34c2bd9a179c2ceb483cacfc3e5a3a - [view on LGTM.com](https://lgtm.com/projects/g/apache/kylin/rev/pr-508d168cbfa59e20262b476d46f47d15e68b1ac8)
**new alerts:**
* 2 for Potential input resource leak
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] zhangayqian commented on pull request #1568: KYLIN-4895: change spark deploy mode of kylin4.0 engine from local to cluster
Posted by GitBox <gi...@apache.org>.
zhangayqian commented on pull request #1568:
URL: https://github.com/apache/kylin/pull/1568#issuecomment-865654489
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org