You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucy.apache.org by nw...@apache.org on 2013/05/11 17:22:13 UTC
[lucy-commits] [3/5] git commit: refs/heads/master - Add some TODO comments
Add some TODO comments
Project: http://git-wip-us.apache.org/repos/asf/lucy/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucy/commit/d20b08df
Tree: http://git-wip-us.apache.org/repos/asf/lucy/tree/d20b08df
Diff: http://git-wip-us.apache.org/repos/asf/lucy/diff/d20b08df
Branch: refs/heads/master
Commit: d20b08df46b768485d1074b022294cc83b453e1b
Parents: 1152f4e
Author: Nick Wellnhofer <we...@aevum.de>
Authored: Sat May 11 15:53:52 2013 +0200
Committer: Nick Wellnhofer <we...@aevum.de>
Committed: Sat May 11 16:34:56 2013 +0200
----------------------------------------------------------------------
clownfish/compiler/src/CFCClass.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucy/blob/d20b08df/clownfish/compiler/src/CFCClass.c
----------------------------------------------------------------------
diff --git a/clownfish/compiler/src/CFCClass.c b/clownfish/compiler/src/CFCClass.c
index 99416b8..e5022ac 100644
--- a/clownfish/compiler/src/CFCClass.c
+++ b/clownfish/compiler/src/CFCClass.c
@@ -239,6 +239,10 @@ CFCClass_destroy(CFCClass *self) {
static void
S_register(CFCClass *self) {
+ /*
+ * TODO: Verify that there isn't a class with the same class_name in
+ * another parcel. Verify that cnick is unique within this parcel.
+ */
if (registry_size == registry_cap) {
size_t new_cap = registry_cap + 10;
registry = (CFCClassRegEntry*)REALLOCATE(
@@ -443,6 +447,7 @@ CFCClass_method(CFCClass *self, const char *sym) {
CFCMethod*
CFCClass_fresh_method(CFCClass *self, const char *sym) {
+ // TODO: Comparing classes by cnick isn't safe with multiple parcels.
CFCMethod *method = CFCClass_method(self, sym);
if (method) {
const char *cnick = CFCClass_get_cnick(self);
@@ -614,6 +619,7 @@ CFCClass_tree_to_ladder(CFCClass *self) {
static CFCSymbol**
S_fresh_syms(CFCClass *self, CFCSymbol **syms) {
+ // TODO: Comparing classes by cnick isn't safe with multiple parcels.
const char *cnick = CFCClass_get_cnick(self);
size_t count = 0;
while (syms[count] != NULL) { count++; }