[GitHub] jvrao commented on a change in pull request #1887: Issue#1886 Handle double bookie failures

[GitBox <gi...@apache.org>]

jvrao commented on a change in pull request #1887: Issue#1886 Handle double bookie failures
URL: https://github.com/apache/bookkeeper/pull/1887#discussion_r241910418
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerHandle.java
 ##########
 @@ -1972,6 +1972,11 @@ void handleBookieFailure(final Map<Integer, BookieSocketAddress> failedBookies)
         }
     }
 
+    boolean testStubResolveConflict() {
+        // No test inserts by default
+        return false;
+    }
+
 
 Review comment:
   I did not like the stub function to inject mock object, but I ran into various complications with mocking inner class methods which are generated on demand. If there is any better way I am more than happy to adopt it. Given that this is not applicable for master I gave pull request to 4.8 only. Not sure if we have a test case in the master to cover this case. @ivankelly ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services