You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "zhangskz (via GitHub)" <gi...@apache.org> on 2023/03/17 17:16:10 UTC
[GitHub] [beam] zhangskz opened a new pull request, #25885: Remove unused checkProto2Syntax from ProtobufUtil.java and test.
zhangskz opened a new pull request, #25885:
URL: https://github.com/apache/beam/pull/25885
ProtobufUtil.checkProto2Syntax is not used in beam and is not publicly exposed.
This type of utility method should also become obsolete in future versions of protobuf.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #25885: Remove unused checkProto2Syntax from ProtobufUtil.java and test.
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #25885:
URL: https://github.com/apache/beam/pull/25885#issuecomment-1488954851
I'm not entirely clear what the use of this function was. I am nervous to commit a breaking change here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25885: Remove unused checkProto2Syntax from ProtobufUtil.java and test.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25885:
URL: https://github.com/apache/beam/pull/25885#issuecomment-1488490337
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @kennknowles for label java.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #25885: Remove unused checkProto2Syntax from ProtobufUtil.java and test.
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #25885:
URL: https://github.com/apache/beam/pull/25885#issuecomment-1488953989
Run Java_GCP_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25885: Remove unused checkProto2Syntax from ProtobufUtil.java and test.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25885:
URL: https://github.com/apache/beam/pull/25885#issuecomment-1483808962
Reminder, please take a look at this pr: @robertwb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles merged pull request #25885: Remove unused checkProto2Syntax from ProtobufUtil.java and test.
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles merged PR #25885:
URL: https://github.com/apache/beam/pull/25885
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #25885: Remove unused checkProto2Syntax from ProtobufUtil.java and test.
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #25885:
URL: https://github.com/apache/beam/pull/25885#issuecomment-1488956554
I see it is non-public anyhow, and seems to be confirming that the tests should fail on their own. I think the functionality may need adjusting too? Should the test of an error message on `Any` no longer cause an error message? It depends on proto version, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #25885: Remove unused checkProto2Syntax from ProtobufUtil.java and test.
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #25885:
URL: https://github.com/apache/beam/pull/25885#issuecomment-1488953688
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] zhangskz commented on pull request #25885: Remove unused checkProto2Syntax from ProtobufUtil.java and test.
Posted by "zhangskz (via GitHub)" <gi...@apache.org>.
zhangskz commented on PR #25885:
URL: https://github.com/apache/beam/pull/25885#issuecomment-1489020009
Anys were introduced for proto3, but should be allowed in proto2 now as well, so this check may be obsolete depending on why this was put in place in the first place. I do see that this function is non-public -- I think this case asserting test protos are proto2 is the only usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #25885: Remove unused checkProto2Syntax from ProtobufUtil.java and test.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #25885:
URL: https://github.com/apache/beam/pull/25885#issuecomment-1474217753
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @robertwb for label java.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #25885: Remove unused checkProto2Syntax from ProtobufUtil.java and test.
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #25885:
URL: https://github.com/apache/beam/pull/25885#issuecomment-1488952567
The flink test appears to be flaky w.r.t. its timeout and probably should not be in the unit test suite.
The firestore failing test has been disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #25885: Remove unused checkProto2Syntax from ProtobufUtil.java and test.
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #25885:
URL: https://github.com/apache/beam/pull/25885#issuecomment-1488953411
I'm not sure if the merge commit that is tested against will change automatically as `master` branch advances or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org