You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/05/16 14:32:24 UTC

[GitHub] [ignite] korlov42 commented on a diff in pull request #10021: IGNITE-16318 Fix write/read/modify empty binary object

korlov42 commented on code in PR #10021:
URL: https://github.com/apache/ignite/pull/10021#discussion_r873801370


##########
modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryWriterExImpl.java:
##########
@@ -325,8 +325,8 @@ else if (offsetByteCnt == BinaryUtils.OFFSET_2)
                 flags |= BinaryUtils.FLAG_HAS_RAW;
             }
             else {
-                finalSchemaId = 0;

Review Comment:
   Objects which serialised by using raw writer only are affected by the very same issue. Looks like we don't need the `finalSchemaId` field at all



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org