You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jonathan Hsieh (JIRA)" <ji...@apache.org> on 2013/09/11 01:33:51 UTC

[jira] [Comment Edited] (HBASE-9495) Sanity check visiblity and audience for hbase-client and hbase-common apis.

    [ https://issues.apache.org/jira/browse/HBASE-9495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13763702#comment-13763702 ] 

Jonathan Hsieh edited comment on HBASE-9495 at 9/10/13 11:32 PM:
-----------------------------------------------------------------

Files from hbase-common missing InterfaceAudience

jon@swoop:~/proj/hbase-trunk/hbase-common/src/main/java$ grep -R -L InterfaceAudience .
./org/apache/hadoop/hbase/CellScannable.java
./org/apache/hadoop/hbase/io/encoding/HFileBlockDecodingContext.java
./org/apache/hadoop/hbase/io/encoding/HFileBlockDefaultDecodingContext.java
./org/apache/hadoop/hbase/io/encoding/HFileBlockEncodingContext.java
./org/apache/hadoop/hbase/io/encoding/HFileBlockDefaultEncodingContext.java
./org/apache/hadoop/hbase/types/package-info.java
./org/apache/hadoop/hbase/codec/KeyValueCodec.java
./org/apache/hadoop/hbase/codec/CellCodec.java
./org/apache/hadoop/hbase/codec/CodecException.java
./org/apache/hadoop/hbase/codec/BaseEncoder.java
./org/apache/hadoop/hbase/codec/Codec.java
./org/apache/hadoop/hbase/codec/BaseDecoder.java
./org/apache/hadoop/hbase/util/test/RedundantKVGenerator.java
./org/apache/hadoop/hbase/util/test/LoadTestKVGenerator.java
./org/apache/hadoop/hbase/util/test/LoadTestDataGenerator.java
./org/apache/hadoop/hbase/util/CollectionUtils.java
./org/apache/hadoop/hbase/util/DrainBarrier.java
./org/apache/hadoop/hbase/util/ReflectionUtils.java
./org/apache/hadoop/hbase/util/Triple.java
./org/apache/hadoop/hbase/util/IterableUtils.java
./org/apache/hadoop/hbase/util/ArrayUtils.java
./org/apache/hadoop/hbase/util/KeyLocker.java

Files in hbase-client missing InterfaceAudience

jon@swoop:~/proj/hbase-trunk/hbase-client/src/main/java$ grep -R -L InterfaceAudience .
./org/apache/hadoop/hbase/client/Registry.java
./org/apache/hadoop/hbase/client/replication/ReplicationAdmin.java
./org/apache/hadoop/hbase/client/HConnectable.java
./org/apache/hadoop/hbase/client/ZooKeeperRegistry.java
./org/apache/hadoop/hbase/client/HConnectionKey.java
./org/apache/hadoop/hbase/client/coprocessor/SecureBulkLoadClient.java
./org/apache/hadoop/hbase/client/coprocessor/package-info.java
./org/apache/hadoop/hbase/client/MultiServerCallable.java
./org/apache/hadoop/hbase/client/MasterMonitorKeepAliveConnection.java
./org/apache/hadoop/hbase/client/ZooKeeperKeepAliveConnection.java
./org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java
./org/apache/hadoop/hbase/client/DelegatingRetryingCallable.java
./org/apache/hadoop/hbase/client/AsyncProcess.java
./org/apache/hadoop/hbase/client/MasterAdminKeepAliveConnection.java
./org/apache/hadoop/hbase/client/WrongRowIOException.java
./org/apache/hadoop/hbase/client/package-info.java
./org/apache/hadoop/hbase/filter/package-info.java
./org/apache/hadoop/hbase/security/AccessDeniedException.java
./org/apache/hadoop/hbase/security/SecureBulkLoadUtil.java
./org/apache/hadoop/hbase/security/access/TablePermission.java
./org/apache/hadoop/hbase/security/access/Permission.java
./org/apache/hadoop/hbase/security/access/UserPermission.java
./org/apache/hadoop/hbase/security/SaslUtil.java
./org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java
./org/apache/hadoop/hbase/security/SecurityInfo.java
./org/apache/hadoop/hbase/security/token/AuthenticationTokenSelector.java
./org/apache/hadoop/hbase/security/token/AuthenticationTokenIdentifier.java
./org/apache/hadoop/hbase/security/AuthMethod.java
./org/apache/hadoop/hbase/security/SaslStatus.java
./org/apache/hadoop/hbase/regionserver/BloomType.java
./org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java
./org/apache/hadoop/hbase/replication/ReplicationTrackerZKImpl.java
./org/apache/hadoop/hbase/replication/ReplicationQueuesClient.java
./org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java
./org/apache/hadoop/hbase/replication/ReplicationFactory.java
./org/apache/hadoop/hbase/replication/ReplicationQueuesZKImpl.java
./org/apache/hadoop/hbase/replication/ReplicationQueuesClientZKImpl.java
./org/apache/hadoop/hbase/replication/ReplicationQueueInfo.java
./org/apache/hadoop/hbase/ipc/ServerRpcController.java
./org/apache/hadoop/hbase/ipc/IPCUtil.java
./org/apache/hadoop/hbase/ipc/UnsupportedCellCodecException.java
./org/apache/hadoop/hbase/ipc/CallerDisconnectedException.java
./org/apache/hadoop/hbase/ipc/UnsupportedCompressionCodecException.java
./org/apache/hadoop/hbase/ipc/StoppedRpcClientException.java
./org/apache/hadoop/hbase/ipc/BadAuthException.java
./org/apache/hadoop/hbase/ipc/WrongVersionException.java
./org/apache/hadoop/hbase/zookeeper/ZKTableReadOnly.java
./org/apache/hadoop/hbase/snapshot/RestoreSnapshotException.java
./org/apache/hadoop/hbase/snapshot/SnapshotCreationException.java
./org/apache/hadoop/hbase/exceptions/UnknownProtocolException.java
./org/apache/hadoop/hbase/exceptions/LockTimeoutException.java
./org/apache/hadoop/hbase/exceptions/FailedSanityCheckException.java
./org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
./org/apache/hadoop/hbase/protobuf/package.html


                
      was (Author: jmhsieh):
    Files from hbase-common missing InterfaceAudience

jon@swoop:~/proj/hbase-trunk/hbase-common/src/main/java$ grep -R -L InterfaceAudience .
./org/apache/hadoop/hbase/io/encoding/HFileBlockDecodingContext.java
./org/apache/hadoop/hbase/io/encoding/HFileBlockDefaultDecodingContext.java
./org/apache/hadoop/hbase/io/encoding/HFileBlockEncodingContext.java
./org/apache/hadoop/hbase/io/encoding/HFileBlockDefaultEncodingContext.java
./org/apache/hadoop/hbase/types/package-info.java
./org/apache/hadoop/hbase/codec/KeyValueCodec.java
./org/apache/hadoop/hbase/codec/CellCodec.java
./org/apache/hadoop/hbase/codec/CodecException.java
./org/apache/hadoop/hbase/codec/BaseEncoder.java
./org/apache/hadoop/hbase/codec/Codec.java
./org/apache/hadoop/hbase/codec/BaseDecoder.java
./org/apache/hadoop/hbase/util/test/RedundantKVGenerator.java
./org/apache/hadoop/hbase/util/test/LoadTestKVGenerator.java
./org/apache/hadoop/hbase/util/test/LoadTestDataGenerator.java
./org/apache/hadoop/hbase/util/CollectionUtils.java
./org/apache/hadoop/hbase/util/DrainBarrier.java
./org/apache/hadoop/hbase/util/ReflectionUtils.java
./org/apache/hadoop/hbase/util/Triple.java
./org/apache/hadoop/hbase/util/IterableUtils.java
./org/apache/hadoop/hbase/util/ArrayUtils.java
./org/apache/hadoop/hbase/util/KeyLocker.java

Files in hbase-client missing InterfaceAudience

jon@swoop:~/proj/hbase-trunk/hbase-client/src/main/java$ grep -R -L InterfaceAudience .
./org/apache/hadoop/hbase/client/Registry.java
./org/apache/hadoop/hbase/client/replication/ReplicationAdmin.java
./org/apache/hadoop/hbase/client/HConnectable.java
./org/apache/hadoop/hbase/client/ZooKeeperRegistry.java
./org/apache/hadoop/hbase/client/HConnectionKey.java
./org/apache/hadoop/hbase/client/coprocessor/SecureBulkLoadClient.java
./org/apache/hadoop/hbase/client/coprocessor/package-info.java
./org/apache/hadoop/hbase/client/MultiServerCallable.java
./org/apache/hadoop/hbase/client/MasterMonitorKeepAliveConnection.java
./org/apache/hadoop/hbase/client/ZooKeeperKeepAliveConnection.java
./org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java
./org/apache/hadoop/hbase/client/DelegatingRetryingCallable.java
./org/apache/hadoop/hbase/client/AsyncProcess.java
./org/apache/hadoop/hbase/client/MasterAdminKeepAliveConnection.java
./org/apache/hadoop/hbase/client/WrongRowIOException.java
./org/apache/hadoop/hbase/client/package-info.java
./org/apache/hadoop/hbase/filter/package-info.java
./org/apache/hadoop/hbase/security/AccessDeniedException.java
./org/apache/hadoop/hbase/security/SecureBulkLoadUtil.java
./org/apache/hadoop/hbase/security/access/TablePermission.java
./org/apache/hadoop/hbase/security/access/Permission.java
./org/apache/hadoop/hbase/security/access/UserPermission.java
./org/apache/hadoop/hbase/security/SaslUtil.java
./org/apache/hadoop/hbase/security/HBaseSaslRpcClient.java
./org/apache/hadoop/hbase/security/SecurityInfo.java
./org/apache/hadoop/hbase/security/token/AuthenticationTokenSelector.java
./org/apache/hadoop/hbase/security/token/AuthenticationTokenIdentifier.java
./org/apache/hadoop/hbase/security/AuthMethod.java
./org/apache/hadoop/hbase/security/SaslStatus.java
./org/apache/hadoop/hbase/regionserver/BloomType.java
./org/apache/hadoop/hbase/replication/ReplicationStateZKBase.java
./org/apache/hadoop/hbase/replication/ReplicationTrackerZKImpl.java
./org/apache/hadoop/hbase/replication/ReplicationQueuesClient.java
./org/apache/hadoop/hbase/replication/ReplicationPeersZKImpl.java
./org/apache/hadoop/hbase/replication/ReplicationFactory.java
./org/apache/hadoop/hbase/replication/ReplicationQueuesZKImpl.java
./org/apache/hadoop/hbase/replication/ReplicationQueuesClientZKImpl.java
./org/apache/hadoop/hbase/replication/ReplicationQueueInfo.java
./org/apache/hadoop/hbase/ipc/ServerRpcController.java
./org/apache/hadoop/hbase/ipc/IPCUtil.java
./org/apache/hadoop/hbase/ipc/UnsupportedCellCodecException.java
./org/apache/hadoop/hbase/ipc/CallerDisconnectedException.java
./org/apache/hadoop/hbase/ipc/UnsupportedCompressionCodecException.java
./org/apache/hadoop/hbase/ipc/StoppedRpcClientException.java
./org/apache/hadoop/hbase/ipc/BadAuthException.java
./org/apache/hadoop/hbase/ipc/WrongVersionException.java
./org/apache/hadoop/hbase/zookeeper/ZKTableReadOnly.java
./org/apache/hadoop/hbase/snapshot/RestoreSnapshotException.java
./org/apache/hadoop/hbase/snapshot/SnapshotCreationException.java
./org/apache/hadoop/hbase/exceptions/UnknownProtocolException.java
./org/apache/hadoop/hbase/exceptions/LockTimeoutException.java
./org/apache/hadoop/hbase/exceptions/FailedSanityCheckException.java
./org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
./org/apache/hadoop/hbase/protobuf/package.html


                  
> Sanity check visiblity and audience for hbase-client and hbase-common apis.
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-9495
>                 URL: https://issues.apache.org/jira/browse/HBASE-9495
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Jonathan Hsieh
>
> This is a task to audit and enumerate places where hbase-common and hbase-client should narrow or widen the exposed user program supported api.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira