You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Michael Wood <mw...@its.uct.ac.za> on 2003/08/01 13:16:52 UTC

Re: [PATCH] svnadmin copy command(Scanned for viruses: Notes Admin)

On Thu, Jul 31, 2003 at 05:26:47PM -0400, vberezniker@siuh.edu wrote:
> Sorry, forgot to include change log:
> 
> Add ability to list all Berkley DB log files not only the unused ones.
> 
> * svnadmin/main.c
>        Add --all-logs option to svnadmin archive command

"archive" doesn't really describe what this command does.  (The same
applies to db_archive.)  The "--all-logs" switch makes this even worse,
IMO.

"archive" prints a list of logs which may be archived or removed without
breaking the database.  "--all-logs" would break that meaning.

-- 
Michael Wood <mw...@its.uct.ac.za>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] svnadmin copy command(Scanned for viruses: Notes Admin)

Posted by vb...@siuh.edu.
I agree about the name "archive" but since I was filling an enhancement 
patch I did not even think of renaming the function.

How about "lsdblogs" and "--all" option to list all logs or did you have a 
different suggestion?

I want to submit a patch for a "copy" command to make hot copy of the 
backup. But in order to do that I need to apply couple of patches to 
enhance subversion functionality. Such as enhanced "archive" command.  I 
figured that since I will enhance the back-end might as well let the user 
see the new functionality.

Luckily for me in rev. 6621 (svn_io_files_contents_same_p) was moved to 
libsvn_subr, that I need as per my log archiving algorithm mentioned in 
the previous email.

Any other suggestions about "archive" command or the way they want to see 
"copy" command implemented?

Sincerely,
Vladimir Berezniker




Michael Wood <mw...@its.uct.ac.za>
08/01/2003 09:16 AM
 
        To:     vberezniker@siuh.edu
        cc:     dev@subversion.tigris.org
        Subject:        Re: [PATCH] svnadmin copy command(Scanned for 
viruses: Notes Admin)


On Thu, Jul 31, 2003 at 05:26:47PM -0400, vberezniker@siuh.edu wrote:
> Sorry, forgot to include change log:
> 
> Add ability to list all Berkley DB log files not only the unused ones.
> 
> * svnadmin/main.c
>        Add --all-logs option to svnadmin archive command

"archive" doesn't really describe what this command does.  (The same
applies to db_archive.)  The "--all-logs" switch makes this even worse,
IMO.

"archive" prints a list of logs which may be archived or removed without
breaking the database.  "--all-logs" would break that meaning.

-- 
Michael Wood <mw...@its.uct.ac.za>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org