You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "rambleraptor (via GitHub)" <gi...@apache.org> on 2026/08/21 19:08:04 UTC
[PR] Fail when explicitly deleted data file is missing [iceberg-python]
rambleraptor opened a new pull request, #3818:
URL: https://github.com/apache/iceberg-python/pull/3818
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace ${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
This looks like the problem I pointed out in #3811 but didn't explain properly enough. We should look for all explicitly deleted files and make sure they exist. This matches how Java handles the situation.
## Are these changes tested?
Included unit tests based off the issue's verification script
## Are there any user-facing changes?
<!-- In the case of user-facing changes, please add the changelog label. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Fail when explicitly deleted data file is missing [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu merged PR #3818:
URL: https://github.com/apache/iceberg-python/pull/3818
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Fail when explicitly deleted data file is missing [iceberg-python]
Posted by "qzyu999 (via GitHub)" <gi...@apache.org>.
qzyu999 commented on PR #3818:
URL: https://github.com/apache/iceberg-python/pull/3818#issuecomment-5420025134
Nice fix! While reviewing this I noticed a related pre-existing gap: `_DeleteFiles` (the `update_snapshot().delete()` path) exposes `delete_data_file()` from its parent class, but calling it silently does nothing because `_compute_deletes` resets `self._deleted_data_files = set()` before scanning by predicate.
This means `_OverwriteFiles` correctly validates explicit deletes (thanks to this PR), but `_DeleteFiles` silently drops them.
Filed as #3857 with a reproduction script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org