[jira] Commented: (PORTLETBRIDGE-3) Bad init param causes infinite loop

["Scott O'Bryan (JIRA)" <de...@myfaces.apache.org>]

    [ https://issues.apache.org/jira/browse/PORTLETBRIDGE-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12544622 ] 

Scott O'Bryan commented on PORTLETBRIDGE-3:
-------------------------------------------

Hey Mike, I looked at this patch and your fix for PortletBridge-14 concerns me as it seems you'll be trading the "IllegalStateException" for a "ClassCastException" when running a render request.

If I understand this correctly, the intention of this interim solution is to make this a noop when we are not in an action request so I'm going to modify your patch with that understanding.  Please review my changes to PortletExternalContextImpl.setCharacterEncoding and let me know if this is what you intended.

> Bad init param causes infinite loop
> -----------------------------------
>
>                 Key: PORTLETBRIDGE-3
>                 URL: https://issues.apache.org/jira/browse/PORTLETBRIDGE-3
>             Project: MyFaces Portlet Bridge
>          Issue Type: Bug
>          Components: API
>    Affects Versions: 1.0.0-SNAPSHOT
>            Reporter: Stan Silvert
>             Fix For: 1.0.0-SNAPSHOT
>
>         Attachments: bridge_patch_1121.patch
>
>
> If the default view for a portlet mode is not specified, you will get an infinite loop.
> In GenericFacesPortlet, the doDispatchInternal() method will call super.doDispatch(request, response) if a default view is not specified in portlet.xml.  GenericPortlet.doDispatch() calls back into GenericFacesPortlet, creating an infinite loop.
> It should throw a PortletException instead.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.