You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/24 19:53:38 UTC
[GitHub] [airflow] potiuk commented on a change in pull request #13308: Adds missing python-ldap dependency to LDAP extra.
potiuk commented on a change in pull request #13308:
URL: https://github.com/apache/airflow/pull/13308#discussion_r548737911
##########
File path: setup.py
##########
@@ -766,9 +766,9 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version
'jdbc': ["jdbc"],
'jenkins': ["jenkins"],
'jira': ["jira"],
- 'kerberos': [],
+ 'kerberos': ["kerberos"],
Review comment:
Seems that we simply miss `python-ldap` dependency (and it goes as far as 1.10.4 https://issues.apache.org/jira/browse/AIRFLOW-5261 and https://apache-airflow.slack.com/archives/C0146STM600/p1608836687492700
##########
File path: setup.py
##########
@@ -766,9 +766,9 @@ def write_version(filename: str = os.path.join(*[my_dir, "airflow", "git_version
'jdbc': ["jdbc"],
'jenkins': ["jenkins"],
'jira': ["jira"],
- 'kerberos': [],
+ 'kerberos': ["kerberos"],
Review comment:
🤦 🤦 . There is also no `ldap` provider either :(. This is a different issue altogether
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org