You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2019/12/27 09:55:55 UTC

[camel] 01/02: Fixed some logging with exceptions

This is an automated email from the ASF dual-hosted git repository.

davsclaus pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git

commit a604067fcc4cf467f4d193bca8523bc9d6b6e494
Author: Claus Ibsen <cl...@gmail.com>
AuthorDate: Fri Dec 27 09:55:59 2019 +0100

    Fixed some logging with exceptions
---
 .../src/main/java/org/apache/camel/impl/engine/ServicePool.java  | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/core/camel-base/src/main/java/org/apache/camel/impl/engine/ServicePool.java b/core/camel-base/src/main/java/org/apache/camel/impl/engine/ServicePool.java
index 3efe0a7..474541a 100644
--- a/core/camel-base/src/main/java/org/apache/camel/impl/engine/ServicePool.java
+++ b/core/camel-base/src/main/java/org/apache/camel/impl/engine/ServicePool.java
@@ -93,7 +93,7 @@ public class ServicePool<S extends Service> extends ServiceSupport implements No
             try {
                 e.getCamelContext().removeService(s);
             } catch (Exception ex) {
-                LOG.error("Error removing service {}", s, ex);
+                LOG.debug("Error removing service: " +  s, ex);
             }
         }
     }
@@ -213,7 +213,7 @@ public class ServicePool<S extends Service> extends ServiceSupport implements No
         try {
             s.stop();
         } catch (Exception e) {
-            LOG.debug("Error stopping service {}", s, e);
+            LOG.debug("Error stopping service: " +  s, e);
         }
     }
 
@@ -241,6 +241,7 @@ public class ServicePool<S extends Service> extends ServiceSupport implements No
 
         @Override
         public void release(S s) {
+            // noop
         }
 
         @Override
@@ -250,7 +251,7 @@ public class ServicePool<S extends Service> extends ServiceSupport implements No
 
         @Override
         public void stop() {
-            S toStop = null;
+            S toStop;
             synchronized (this) {
                 toStop = s;
                 s = null;
@@ -275,7 +276,7 @@ public class ServicePool<S extends Service> extends ServiceSupport implements No
                 try {
                     endpoint.getCamelContext().removeService(s);
                 } catch (Exception e) {
-                    LOG.debug("Error removing service {}", s, e);
+                    LOG.debug("Error removing service: " +  s, e);
                 }
             }
         }