You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2017/06/14 10:00:17 UTC
Review Request 60072: Updated tests to use the test utilities with
reservation refinement.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60072/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-7670
https://issues.apache.org/jira/browse/MESOS-7670
Repository: mesos
Description
-------
Updated tests to use the test utilities with reservation refinement.
Diffs
-----
include/mesos/resources.hpp 2b55847be79c7930b598ef31c932e8aca0fa73db
include/mesos/v1/resources.hpp 7c6e8569b990ad34fd6c449b31140f844dae222f
src/cli/execute.cpp 11a2569f788a2ee1ceaf13ab0d40d1d1b275f27a
src/common/resources.cpp 7b3fae1a34150964ba3831a3aef2f868e338aef8
src/examples/dynamic_reservation_framework.cpp 41228145cf2249e383166a47a3ac33fb2bee27c9
src/examples/persistent_volume_framework.cpp ab4597d1fb61f631cd3f52479ae68dcc5e4cd394
src/examples/test_framework.cpp 05ddc89d953d9b968b78f98fec819aeda7f79e26
src/examples/test_http_framework.cpp 471835c349e0da031a540ed48881227a25887ba7
src/tests/api_tests.cpp 91b3473452b8e65cab9f2e873837d64a0edf4b54
src/tests/default_executor_tests.cpp a76ece5a2832d3a006476672e443573d60d991e9
src/tests/hierarchical_allocator_tests.cpp d6c5904b6e8af6ed8e8387de5e635fb4c920dd08
src/tests/master_quota_tests.cpp 6ca45706f47b7d75db519f98af64e6a52091eb84
src/tests/master_validation_tests.cpp 4e7ce74edf0069b9317f869b299694a45e2a62f2
src/tests/mesos.hpp 48072a976cdbe6e655dc6f5f258abc6d737ed068
src/tests/persistent_volume_endpoints_tests.cpp 0cb969cf06a123504720440f436ecb027d1e138a
src/tests/reservation_endpoints_tests.cpp ba283ee74fe27998a01c43e1ab6a8ce0089181fa
src/tests/reservation_tests.cpp 6e9c215382ef41700921a673669ac1a7975e9b7f
src/tests/resources_tests.cpp b5913860bf4908d0a8fa2c3b9060823bce41bc25
src/tests/role_tests.cpp 56422b507a0863ac1d9395eee63820291c2a4df5
src/tests/slave_recovery_tests.cpp 38502584186793686f78ff5f4e03f36a3bf7ad1c
src/tests/slave_tests.cpp 26901f4294ee74e9f8ac57f2b506d369ea540a15
src/tests/upgrade_tests.cpp dfe77e706e3a8cf0897a8895f747b9d51d47128e
src/v1/resources.cpp 236fe17730918479a33314e51d14f3cc1679d432
Diff: https://reviews.apache.org/r/60072/diff/1/
Testing
-------
Thanks,
Michael Park
Re: Review Request 60072: Updated tests to use the test utilities with
reservation refinement.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60072/#review178020
-----------------------------------------------------------
This patch needs rebasing:
```
[reservation-refinement 1782cba65] Updated test utilities for reservation refinement.
Author: Michael Park <mp...@apache.org>
1 file changed, 72 insertions(+), 27 deletions(-)
2017-06-15 10:48:49 URL:https://reviews.apache.org/r/60072/diff/raw/ [112961/112961] -> "60072.patch" [1]
error: patch failed: src/tests/reservation_tests.cpp:2233
error: src/tests/reservation_tests.cpp: patch does not apply
```
- Neil Conway
On June 14, 2017, 10:44 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60072/
> -----------------------------------------------------------
>
> (Updated June 14, 2017, 10:44 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-7670
> https://issues.apache.org/jira/browse/MESOS-7670
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated tests to use the test utilities with reservation refinement.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 2b55847be79c7930b598ef31c932e8aca0fa73db
> include/mesos/v1/resources.hpp 7c6e8569b990ad34fd6c449b31140f844dae222f
> src/cli/execute.cpp 11a2569f788a2ee1ceaf13ab0d40d1d1b275f27a
> src/common/resources.cpp 7b3fae1a34150964ba3831a3aef2f868e338aef8
> src/examples/dynamic_reservation_framework.cpp 41228145cf2249e383166a47a3ac33fb2bee27c9
> src/examples/persistent_volume_framework.cpp ab4597d1fb61f631cd3f52479ae68dcc5e4cd394
> src/examples/test_framework.cpp 05ddc89d953d9b968b78f98fec819aeda7f79e26
> src/examples/test_http_framework.cpp 471835c349e0da031a540ed48881227a25887ba7
> src/tests/api_tests.cpp 91b3473452b8e65cab9f2e873837d64a0edf4b54
> src/tests/default_executor_tests.cpp a76ece5a2832d3a006476672e443573d60d991e9
> src/tests/hierarchical_allocator_tests.cpp d6c5904b6e8af6ed8e8387de5e635fb4c920dd08
> src/tests/master_quota_tests.cpp 6ca45706f47b7d75db519f98af64e6a52091eb84
> src/tests/master_validation_tests.cpp 4e7ce74edf0069b9317f869b299694a45e2a62f2
> src/tests/mesos.hpp 48072a976cdbe6e655dc6f5f258abc6d737ed068
> src/tests/persistent_volume_endpoints_tests.cpp 0cb969cf06a123504720440f436ecb027d1e138a
> src/tests/reservation_endpoints_tests.cpp ba283ee74fe27998a01c43e1ab6a8ce0089181fa
> src/tests/reservation_tests.cpp 6e9c215382ef41700921a673669ac1a7975e9b7f
> src/tests/resources_tests.cpp b5913860bf4908d0a8fa2c3b9060823bce41bc25
> src/tests/role_tests.cpp 56422b507a0863ac1d9395eee63820291c2a4df5
> src/tests/slave_recovery_tests.cpp 38502584186793686f78ff5f4e03f36a3bf7ad1c
> src/tests/slave_tests.cpp 26901f4294ee74e9f8ac57f2b506d369ea540a15
> src/tests/upgrade_tests.cpp dfe77e706e3a8cf0897a8895f747b9d51d47128e
> src/v1/resources.cpp 236fe17730918479a33314e51d14f3cc1679d432
>
>
> Diff: https://reviews.apache.org/r/60072/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 60072: Updated tests to use the test utilities with
reservation refinement.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60072/#review177932
-----------------------------------------------------------
src/cli/execute.cpp
Lines 502 (patched)
<https://reviews.apache.org/r/60072/#comment251646>
does this work even if role is `*` ?
src/examples/persistent_volume_framework.cpp
Lines 583 (patched)
<https://reviews.apache.org/r/60072/#comment251644>
why is this the only test framework that needs the capability? curious.
src/examples/test_framework.cpp
Line 111 (original), 111 (patched)
<https://reviews.apache.org/r/60072/#comment251648>
curious why "*" needs to be tackled differently here but not in test_http_framework.cpp and cli/execute.cpp?
src/tests/master_quota_tests.cpp
Lines 315 (patched)
<https://reviews.apache.org/r/60072/#comment251649>
can you add a comment here on why you are if def'ing this out?
src/tests/mesos.hpp
Lines 1703-1708 (original), 1703-1706 (patched)
<https://reviews.apache.org/r/60072/#comment251653>
hmm. why this change?
src/tests/reservation_tests.cpp
Lines 2236-2240 (original), 2227-2231 (patched)
<https://reviews.apache.org/r/60072/#comment251655>
a bit weird that `createFrameworkInfo` sets role and this over-rides it here. maybe the helper can take a role as argument?
src/tests/resources_tests.cpp
Line 331 (original), 329 (patched)
<https://reviews.apache.org/r/60072/#comment251657>
so the top level `role` in JSON never went into a release and that's why it's ok to break the format?
src/tests/slave_recovery_tests.cpp
Line 148 (original), 148 (patched)
<https://reviews.apache.org/r/60072/#comment251658>
ASSERT_SOME(actual_) ?
- Vinod Kone
On June 14, 2017, 10:44 a.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60072/
> -----------------------------------------------------------
>
> (Updated June 14, 2017, 10:44 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-7670
> https://issues.apache.org/jira/browse/MESOS-7670
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated tests to use the test utilities with reservation refinement.
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 2b55847be79c7930b598ef31c932e8aca0fa73db
> include/mesos/v1/resources.hpp 7c6e8569b990ad34fd6c449b31140f844dae222f
> src/cli/execute.cpp 11a2569f788a2ee1ceaf13ab0d40d1d1b275f27a
> src/common/resources.cpp 7b3fae1a34150964ba3831a3aef2f868e338aef8
> src/examples/dynamic_reservation_framework.cpp 41228145cf2249e383166a47a3ac33fb2bee27c9
> src/examples/persistent_volume_framework.cpp ab4597d1fb61f631cd3f52479ae68dcc5e4cd394
> src/examples/test_framework.cpp 05ddc89d953d9b968b78f98fec819aeda7f79e26
> src/examples/test_http_framework.cpp 471835c349e0da031a540ed48881227a25887ba7
> src/tests/api_tests.cpp 91b3473452b8e65cab9f2e873837d64a0edf4b54
> src/tests/default_executor_tests.cpp a76ece5a2832d3a006476672e443573d60d991e9
> src/tests/hierarchical_allocator_tests.cpp d6c5904b6e8af6ed8e8387de5e635fb4c920dd08
> src/tests/master_quota_tests.cpp 6ca45706f47b7d75db519f98af64e6a52091eb84
> src/tests/master_validation_tests.cpp 4e7ce74edf0069b9317f869b299694a45e2a62f2
> src/tests/mesos.hpp 48072a976cdbe6e655dc6f5f258abc6d737ed068
> src/tests/persistent_volume_endpoints_tests.cpp 0cb969cf06a123504720440f436ecb027d1e138a
> src/tests/reservation_endpoints_tests.cpp ba283ee74fe27998a01c43e1ab6a8ce0089181fa
> src/tests/reservation_tests.cpp 6e9c215382ef41700921a673669ac1a7975e9b7f
> src/tests/resources_tests.cpp b5913860bf4908d0a8fa2c3b9060823bce41bc25
> src/tests/role_tests.cpp 56422b507a0863ac1d9395eee63820291c2a4df5
> src/tests/slave_recovery_tests.cpp 38502584186793686f78ff5f4e03f36a3bf7ad1c
> src/tests/slave_tests.cpp 26901f4294ee74e9f8ac57f2b506d369ea540a15
> src/tests/upgrade_tests.cpp dfe77e706e3a8cf0897a8895f747b9d51d47128e
> src/v1/resources.cpp 236fe17730918479a33314e51d14f3cc1679d432
>
>
> Diff: https://reviews.apache.org/r/60072/diff/4/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 60072: Adjusted tests to the new resource format
[19/N].
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60072/
-----------------------------------------------------------
(Updated June 19, 2017, 10:36 p.m.)
Review request for mesos and Vinod Kone.
Summary (updated)
-----------------
Adjusted tests to the new resource format [19/N].
Bugs: MESOS-7670
https://issues.apache.org/jira/browse/MESOS-7670
Repository: mesos
Description (updated)
-------
Adjusted tests to the new resource format [19/N].
Diffs (updated)
-----
src/examples/dynamic_reservation_framework.cpp 41228145cf2249e383166a47a3ac33fb2bee27c9
src/examples/test_framework.cpp 05ddc89d953d9b968b78f98fec819aeda7f79e26
src/examples/test_http_framework.cpp 471835c349e0da031a540ed48881227a25887ba7
src/tests/api_tests.cpp c40f5ccf4254de6ba10e83579006003f6c8a87dd
src/tests/default_executor_tests.cpp a76ece5a2832d3a006476672e443573d60d991e9
src/tests/hierarchical_allocator_tests.cpp d6c5904b6e8af6ed8e8387de5e635fb4c920dd08
src/tests/master_quota_tests.cpp 6ca45706f47b7d75db519f98af64e6a52091eb84
src/tests/master_validation_tests.cpp 83370fa5653fe5da666ec577b05001c4a5499848
src/tests/persistent_volume_endpoints_tests.cpp 0cb969cf06a123504720440f436ecb027d1e138a
src/tests/persistent_volume_tests.cpp 787141cdbe0188ba839d3bbd6e5cbb97ff78ce4b
src/tests/reservation_endpoints_tests.cpp ba283ee74fe27998a01c43e1ab6a8ce0089181fa
src/tests/reservation_tests.cpp daebfdfa2aa0af9656e51d1a429ec2470aef7f6a
src/tests/resources_tests.cpp a44490a4f4fbd3af3b95c9e9a167a96c6e0f40f9
src/tests/role_tests.cpp 850dfa79646562bd3653a5fd0f079d0226b95970
src/tests/slave_recovery_tests.cpp 38502584186793686f78ff5f4e03f36a3bf7ad1c
src/tests/slave_tests.cpp 26901f4294ee74e9f8ac57f2b506d369ea540a15
src/tests/upgrade_tests.cpp dfe77e706e3a8cf0897a8895f747b9d51d47128e
Diff: https://reviews.apache.org/r/60072/diff/7/
Changes: https://reviews.apache.org/r/60072/diff/6-7/
Testing
-------
Thanks,
Michael Park
Re: Review Request 60072: Updated tests to use the test utilities with
reservation refinement.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60072/
-----------------------------------------------------------
(Updated June 14, 2017, 3:44 a.m.)
Review request for mesos and Vinod Kone.
Bugs: MESOS-7670
https://issues.apache.org/jira/browse/MESOS-7670
Repository: mesos
Description
-------
Updated tests to use the test utilities with reservation refinement.
Diffs (updated)
-----
include/mesos/resources.hpp 2b55847be79c7930b598ef31c932e8aca0fa73db
include/mesos/v1/resources.hpp 7c6e8569b990ad34fd6c449b31140f844dae222f
src/cli/execute.cpp 11a2569f788a2ee1ceaf13ab0d40d1d1b275f27a
src/common/resources.cpp 7b3fae1a34150964ba3831a3aef2f868e338aef8
src/examples/dynamic_reservation_framework.cpp 41228145cf2249e383166a47a3ac33fb2bee27c9
src/examples/persistent_volume_framework.cpp ab4597d1fb61f631cd3f52479ae68dcc5e4cd394
src/examples/test_framework.cpp 05ddc89d953d9b968b78f98fec819aeda7f79e26
src/examples/test_http_framework.cpp 471835c349e0da031a540ed48881227a25887ba7
src/tests/api_tests.cpp 91b3473452b8e65cab9f2e873837d64a0edf4b54
src/tests/default_executor_tests.cpp a76ece5a2832d3a006476672e443573d60d991e9
src/tests/hierarchical_allocator_tests.cpp d6c5904b6e8af6ed8e8387de5e635fb4c920dd08
src/tests/master_quota_tests.cpp 6ca45706f47b7d75db519f98af64e6a52091eb84
src/tests/master_validation_tests.cpp 4e7ce74edf0069b9317f869b299694a45e2a62f2
src/tests/mesos.hpp 48072a976cdbe6e655dc6f5f258abc6d737ed068
src/tests/persistent_volume_endpoints_tests.cpp 0cb969cf06a123504720440f436ecb027d1e138a
src/tests/reservation_endpoints_tests.cpp ba283ee74fe27998a01c43e1ab6a8ce0089181fa
src/tests/reservation_tests.cpp 6e9c215382ef41700921a673669ac1a7975e9b7f
src/tests/resources_tests.cpp b5913860bf4908d0a8fa2c3b9060823bce41bc25
src/tests/role_tests.cpp 56422b507a0863ac1d9395eee63820291c2a4df5
src/tests/slave_recovery_tests.cpp 38502584186793686f78ff5f4e03f36a3bf7ad1c
src/tests/slave_tests.cpp 26901f4294ee74e9f8ac57f2b506d369ea540a15
src/tests/upgrade_tests.cpp dfe77e706e3a8cf0897a8895f747b9d51d47128e
src/v1/resources.cpp 236fe17730918479a33314e51d14f3cc1679d432
Diff: https://reviews.apache.org/r/60072/diff/4/
Changes: https://reviews.apache.org/r/60072/diff/3-4/
Testing
-------
Thanks,
Michael Park