[GitHub] [geode] albertogpz commented on a change in pull request #6193: GEODE-9063: Autocomplete with mandatory params first

[GitBox <gi...@apache.org>]

albertogpz commented on a change in pull request #6193:
URL: https://github.com/apache/geode/pull/6193#discussion_r609807805



##########
File path: geode-gfsh/src/integrationTest/java/org/apache/geode/management/internal/cli/GfshParserAutoCompletionIntegrationTest.java
##########
@@ -447,4 +447,124 @@ public void testCompletionCreateGatewaySenderWithDash() {
     assertThat(candidate.getCandidates()).hasSize(1);
     assertThat(candidate.getFirstCandidate()).isEqualTo(buffer + "id");
   }
+
+  @Test
+  public void forChangeLogLevelWithSpaceCompletionOffersMandatoryOptionsInAlphabeticalOrder() {

Review comment:
       I would rename this test case and the rest to align them with the ones already testing something similar, like for example, testCompletionCreateGatewaySenderWithSpace.
   
   In this case, the name would be: testCompletionChangeLogLevelWithSpace.
   If you want to add also the expected outcome in the name like you already have in your original proposal, better.
   
   This comments applies to all new test cases.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org