You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by skidder <gi...@git.apache.org> on 2017/06/28 20:43:52 UTC
[GitHub] flink pull request #4214: [FLINK-7021]
GitHub user skidder opened a pull request:
https://github.com/apache/flink/pull/4214
[FLINK-7021]
Fixes issue FLINK-7021 by adding an `UnhandledErrorListener` implementation to the Task Manager that will shutdown the Task Manager if an unretryable exception is raised while retrieving the Zookeeper leader.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/muxinc/flink FLINK-7021
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4214.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4214
----
commit 02cd39e5b5c8b7e1936776476566b5363b40004f
Author: Scott Kidder <sc...@mux.com>
Date: 2017-06-28T14:48:33Z
[FLINK-7021] [core] Handle Zookeeper leader retrieval error in TaskManager and throw RuntimeException
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4214: [FLINK-7021] Flink Task Manager hangs on startup if one Z...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4214
@skidder Do you want to follow up on this one? Otherwise, another contributor might take this over.
Betting this fix into 1.4 would be great...
---
[GitHub] flink issue #4214: [FLINK-7021] Flink Task Manager hangs on startup if one Z...
Posted by skidder <gi...@git.apache.org>.
Github user skidder commented on the issue:
https://github.com/apache/flink/pull/4214
Sorry for not responding sooner! Thank you @StephanEwen and @tillrohrmann for applying this fix!
---
[GitHub] flink issue #4214: [FLINK-7021] Flink Task Manager hangs on startup if one Z...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4214
I'll address my comment myself and then merge the PR. Thanks a lot for your contribution @skidder.
---
[GitHub] flink pull request #4214: [FLINK-7021] Flink Task Manager hangs on startup i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4214
---
[GitHub] flink pull request #4214: [FLINK-7021] Flink Task Manager hangs on startup i...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4214#discussion_r132162054
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/leaderretrieval/ZooKeeperLeaderRetrievalService.java ---
@@ -196,4 +198,12 @@ protected void handleStateChange(ConnectionState newState) {
break;
}
}
+
+ @Override
+ public void unhandledError(String s, Throwable throwable) {
+ LOG.warn("Unhandled error encountered while retrieving Zookeeper leader.");
+ final RuntimeException e = new RuntimeException(s, throwable);
+ this.leaderListener.handleError(e);
+ throw e;
--- End diff --
I think it should be enough to call `this.leaderListener.handleError`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---