You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by revans2 <gi...@git.apache.org> on 2015/04/28 22:42:25 UTC

[GitHub] storm pull request: STORM-603 Log errors when required kafka param...

Github user revans2 commented on the pull request:

    https://github.com/apache/storm/pull/361#issuecomment-97201701
  
    @curtisallen Sorry it has taken so long to review this.  I think the changes look OK.  I am curious why we only logging an error instead of throwing an exception.  Wouldn't we just end up throwing an NPE later on in the code?  Why not fail fast?
    
    @harshach did @curtisallen answer all of your questions?  Do you have any other follow up?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---