You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tubemq.apache.org by GitBox <gi...@apache.org> on 2020/01/08 08:14:25 UTC

[GitHub] [incubator-tubemq] Technoboy- opened a new pull request #4: TUBEMQ-10 javadoc error

Technoboy- opened a new pull request #4: TUBEMQ-10 javadoc error
URL: https://github.com/apache/incubator-tubemq/pull/4
 
 
   https://issues.apache.org/jira/browse/TUBEMQ-10

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tubemq] chenjunjiedada commented on issue #4: TUBEMQ-10 javadoc error

Posted by GitBox <gi...@apache.org>.
chenjunjiedada commented on issue #4: TUBEMQ-10 javadoc error
URL: https://github.com/apache/incubator-tubemq/pull/4#issuecomment-571962690
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tubemq] TisonKun commented on issue #4: TUBEMQ-10 javadoc error

Posted by GitBox <gi...@apache.org>.
TisonKun commented on issue #4: TUBEMQ-10 javadoc error
URL: https://github.com/apache/incubator-tubemq/pull/4#issuecomment-571976371
 
 
   FYI https://lists.apache.org/x/thread.html/rb478cc59ca720d1ca9a6c1a2616108383fc7735a770284afe56d508b@%3Cdev.tubemq.apache.org%3E
   
   cc @yiheng 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tubemq] chenjunjiedada removed a comment on issue #4: TUBEMQ-10 javadoc error

Posted by GitBox <gi...@apache.org>.
chenjunjiedada removed a comment on issue #4: TUBEMQ-10 javadoc error
URL: https://github.com/apache/incubator-tubemq/pull/4#issuecomment-571962690
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tubemq] kaynewu commented on issue #4: TUBEMQ-10 javadoc error

Posted by GitBox <gi...@apache.org>.
kaynewu commented on issue #4: TUBEMQ-10 javadoc error
URL: https://github.com/apache/incubator-tubemq/pull/4#issuecomment-571969410
 
 
   +1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tubemq] chenjunjiedada merged pull request #4: TUBEMQ-10 javadoc error

Posted by GitBox <gi...@apache.org>.
chenjunjiedada merged pull request #4: TUBEMQ-10 javadoc error
URL: https://github.com/apache/incubator-tubemq/pull/4
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tubemq] TisonKun commented on issue #4: TUBEMQ-10 javadoc error

Posted by GitBox <gi...@apache.org>.
TisonKun commented on issue #4: TUBEMQ-10 javadoc error
URL: https://github.com/apache/incubator-tubemq/pull/4#issuecomment-571976067
 
 
   Hi @chenjunjiedada , please prefer "Squash And Merge" which doesn't produce a redundant merge commit.
   
   We are discussing on dev mailing list about how to handle contribution and merging commits. Feel free to share your idea there but don't rush into merging prs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services