You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Benno Evers <be...@yandex-team.ru> on 2017/09/13 14:52:45 UTC

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62212/
-----------------------------------------------------------

(Updated Sept. 13, 2017, 2:52 p.m.)


Review request for mesos, Andrei Budnik and Alexander Rukletsov.


Changes
-------

Send task starting slightly later; initialize containers slightly earlier


Summary (updated)
-----------------

Send TASK_STARTING from the built-in executors.


Bugs: MESOS-7941
    https://issues.apache.org/jira/browse/MESOS-7941


Repository: mesos


Description
-------

This gives schedulers more information about a tasks status,
in particular it gives a better estimate of a tasks start time
and helps differentiating between tasks stuck in TASK_STAGING
and tasks stuck in TASK_STARTING.


Diffs (updated)
-----

  docs/high-availability-framework-guide.md 73743aba31f9d0ca827d318e2ecb4752a91b1be0 
  src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79 
  src/launcher/default_executor.cpp 106b7f2e0244d211c66b237b5d1c51f43fc6e529 
  src/launcher/executor.cpp 951597b576b4912541dd87d52dcb981393e58082 


Diff: https://reviews.apache.org/r/62212/diff/2/

Changes: https://reviews.apache.org/r/62212/diff/1-2/


Testing
-------


Thanks,

Benno Evers

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

Posted by Benno Evers <be...@yandex-team.ru>.


> On Sept. 13, 2017, 5:29 p.m., Andrei Budnik wrote:
> > src/launcher/default_executor.cpp
> > Line 326 (original), 332 (patched)
> > <https://reviews.apache.org/r/62212/diff/2/?file=1820838#file1820838line332>
> >
> >     Should we update the comment above?

I think the comment is still correct.


> On Sept. 13, 2017, 5:29 p.m., Andrei Budnik wrote:
> > src/launcher/default_executor.cpp
> > Lines 412 (patched)
> > <https://reviews.apache.org/r/62212/diff/2/?file=1820838#file1820838line412>
> >
> >     Adding default constructor for `DefaultExecutor::Container` will help us to get rid of repeating `None()` and `false`.

I'm not sure about adding a function that will be called only once.


- Benno


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62212/#review185310
-----------------------------------------------------------


On Sept. 13, 2017, 2:52 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62212/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2017, 2:52 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-7941
>     https://issues.apache.org/jira/browse/MESOS-7941
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This gives schedulers more information about a tasks status,
> in particular it gives a better estimate of a tasks start time
> and helps differentiating between tasks stuck in TASK_STAGING
> and tasks stuck in TASK_STARTING.
> 
> 
> Diffs
> -----
> 
>   docs/high-availability-framework-guide.md 73743aba31f9d0ca827d318e2ecb4752a91b1be0 
>   src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79 
>   src/launcher/default_executor.cpp 106b7f2e0244d211c66b237b5d1c51f43fc6e529 
>   src/launcher/executor.cpp 951597b576b4912541dd87d52dcb981393e58082 
> 
> 
> Diff: https://reviews.apache.org/r/62212/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

Posted by Andrei Budnik <ab...@mesosphere.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62212/#review185310
-----------------------------------------------------------




src/docker/executor.cpp
Lines 160 (patched)
<https://reviews.apache.org/r/62212/#comment261616>

    Consider moving this comment right after `LOG(INFO) << "Starting task " << taskId.get();`.



src/launcher/default_executor.cpp
Line 326 (original), 332 (patched)
<https://reviews.apache.org/r/62212/#comment261617>

    Should we update the comment above?



src/launcher/default_executor.cpp
Lines 412 (patched)
<https://reviews.apache.org/r/62212/#comment261618>

    Adding default constructor for `DefaultExecutor::Container` will help us to get rid of repeating `None()` and `false`.



src/launcher/executor.cpp
Line 1019 (original), 1023 (patched)
<https://reviews.apache.org/r/62212/#comment261612>

    As you have moved
    ```c++
    TaskStatus starting = createTaskStatus(taskId.get(), TASK_STARTING);
    forward(starting);
    ```
    after `taskData = TaskData(task);`, this change is not necessarry anymore and can be reverted.


- Andrei Budnik


On Sept. 13, 2017, 2:52 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62212/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2017, 2:52 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-7941
>     https://issues.apache.org/jira/browse/MESOS-7941
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This gives schedulers more information about a tasks status,
> in particular it gives a better estimate of a tasks start time
> and helps differentiating between tasks stuck in TASK_STAGING
> and tasks stuck in TASK_STARTING.
> 
> 
> Diffs
> -----
> 
>   docs/high-availability-framework-guide.md 73743aba31f9d0ca827d318e2ecb4752a91b1be0 
>   src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79 
>   src/launcher/default_executor.cpp 106b7f2e0244d211c66b237b5d1c51f43fc6e529 
>   src/launcher/executor.cpp 951597b576b4912541dd87d52dcb981393e58082 
> 
> 
> Diff: https://reviews.apache.org/r/62212/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

Posted by Benno Evers <be...@yandex-team.ru>.


> On Sept. 15, 2017, 11:36 a.m., Andrei Budnik wrote:
> > src/launcher/default_executor.cpp
> > Line 1379 (original), 1396 (patched)
> > <https://reviews.apache.org/r/62212/diff/2/?file=1820838#file1820838line1406>
> >
> >     If a default executor is allowed to call `launchGroup` more than once, then there may be a case when some containers are launched already, while others not.

I think if this is possible, the error was already in the existing code?


- Benno


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62212/#review185478
-----------------------------------------------------------


On Sept. 13, 2017, 2:52 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62212/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2017, 2:52 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-7941
>     https://issues.apache.org/jira/browse/MESOS-7941
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This gives schedulers more information about a tasks status,
> in particular it gives a better estimate of a tasks start time
> and helps differentiating between tasks stuck in TASK_STAGING
> and tasks stuck in TASK_STARTING.
> 
> 
> Diffs
> -----
> 
>   docs/high-availability-framework-guide.md 73743aba31f9d0ca827d318e2ecb4752a91b1be0 
>   src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79 
>   src/launcher/default_executor.cpp 106b7f2e0244d211c66b237b5d1c51f43fc6e529 
>   src/launcher/executor.cpp 951597b576b4912541dd87d52dcb981393e58082 
> 
> 
> Diff: https://reviews.apache.org/r/62212/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

Posted by Andrei Budnik <ab...@mesosphere.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62212/#review185478
-----------------------------------------------------------




src/launcher/default_executor.cpp
Line 1379 (original), 1396 (patched)
<https://reviews.apache.org/r/62212/#comment261769>

    If a default executor is allowed to call `launchGroup` more than once, then there may be a case when some containers are launched already, while others not.


- Andrei Budnik


On Sept. 13, 2017, 2:52 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62212/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2017, 2:52 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-7941
>     https://issues.apache.org/jira/browse/MESOS-7941
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This gives schedulers more information about a tasks status,
> in particular it gives a better estimate of a tasks start time
> and helps differentiating between tasks stuck in TASK_STAGING
> and tasks stuck in TASK_STARTING.
> 
> 
> Diffs
> -----
> 
>   docs/high-availability-framework-guide.md 73743aba31f9d0ca827d318e2ecb4752a91b1be0 
>   src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79 
>   src/launcher/default_executor.cpp 106b7f2e0244d211c66b237b5d1c51f43fc6e529 
>   src/launcher/executor.cpp 951597b576b4912541dd87d52dcb981393e58082 
> 
> 
> Diff: https://reviews.apache.org/r/62212/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

Posted by Alexander Rukletsov <ru...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62212/#review187711
-----------------------------------------------------------




src/launcher/default_executor.cpp
Lines 489-490 (patched)
<https://reviews.apache.org/r/62212/#comment264760>

    You don't need to explicitly call out `None()`. As a bonus, you can fit it in one line : )



src/launcher/default_executor.cpp
Lines 528-529 (original), 555-556 (patched)
<https://reviews.apache.org/r/62212/#comment264758>

    Please check the internal invariant:
    `CHECK(containers.contains(taskId));`


- Alexander Rukletsov


On Oct. 11, 2017, 10:28 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62212/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2017, 10:28 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-7941
>     https://issues.apache.org/jira/browse/MESOS-7941
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This gives schedulers more information about a tasks status,
> in particular it gives a better estimate of a tasks start time
> and helps differentiating between tasks stuck in TASK_STAGING
> and tasks stuck in TASK_STARTING.
> 
> 
> Diffs
> -----
> 
>   docs/high-availability-framework-guide.md 73743aba31f9d0ca827d318e2ecb4752a91b1be0 
>   src/docker/executor.cpp 3b0767ffbbe9982639d0b87fbb0573accdd48559 
>   src/launcher/default_executor.cpp 136c000917b2c4fdaf68fd460764c3a15fdf3bf0 
>   src/launcher/executor.cpp 0131577d5b9018e7094815f1377b2ee59a4493d4 
> 
> 
> Diff: https://reviews.apache.org/r/62212/diff/4/
> 
> 
> Testing
> -------
> 
> * `make check`
> * Installed in local DC/OS cluster and successfully completed the tweeter tutorial
> * Installed in local DC/OS cluster and successfully ran a periodic sleep task using chronos.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

Posted by Alexander Rukletsov <ru...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62212/#review187808
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On Oct. 12, 2017, 11:20 a.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62212/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2017, 11:20 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-7941
>     https://issues.apache.org/jira/browse/MESOS-7941
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This gives schedulers more information about a tasks status,
> in particular it gives a better estimate of a tasks start time
> and helps differentiating between tasks stuck in TASK_STAGING
> and tasks stuck in TASK_STARTING.
> 
> 
> Diffs
> -----
> 
>   docs/high-availability-framework-guide.md 73743aba31f9d0ca827d318e2ecb4752a91b1be0 
>   src/docker/executor.cpp 3b0767ffbbe9982639d0b87fbb0573accdd48559 
>   src/launcher/default_executor.cpp 136c000917b2c4fdaf68fd460764c3a15fdf3bf0 
>   src/launcher/executor.cpp 0131577d5b9018e7094815f1377b2ee59a4493d4 
> 
> 
> Diff: https://reviews.apache.org/r/62212/diff/6/
> 
> 
> Testing
> -------
> 
> (for the complete chain starting with this RR)
> - `make check`
> - Installed in local DC/OS cluster and successfully completed the tweeter tutorial
> - Installed in local DC/OS cluster and successfully ran a periodic sleep task using chronos.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 62212: Send TASK_STARTING from the built-in executors.

Posted by Andrei Budnik <ab...@mesosphere.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62212/#review187772
-----------------------------------------------------------


Ship it!




Ship It!

- Andrei Budnik


On Oct. 12, 2017, 11:20 a.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62212/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2017, 11:20 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-7941
>     https://issues.apache.org/jira/browse/MESOS-7941
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This gives schedulers more information about a tasks status,
> in particular it gives a better estimate of a tasks start time
> and helps differentiating between tasks stuck in TASK_STAGING
> and tasks stuck in TASK_STARTING.
> 
> 
> Diffs
> -----
> 
>   docs/high-availability-framework-guide.md 73743aba31f9d0ca827d318e2ecb4752a91b1be0 
>   src/docker/executor.cpp 3b0767ffbbe9982639d0b87fbb0573accdd48559 
>   src/launcher/default_executor.cpp 136c000917b2c4fdaf68fd460764c3a15fdf3bf0 
>   src/launcher/executor.cpp 0131577d5b9018e7094815f1377b2ee59a4493d4 
> 
> 
> Diff: https://reviews.apache.org/r/62212/diff/6/
> 
> 
> Testing
> -------
> 
> (for the complete chain starting with this RR)
> - `make check`
> - Installed in local DC/OS cluster and successfully completed the tweeter tutorial
> - Installed in local DC/OS cluster and successfully ran a periodic sleep task using chronos.
> 
> 
> Thanks,
> 
> Benno Evers
> 
>