You are viewing a plain text version of this content. The canonical link for it is here.

Posted to users@wicket.apache.org by pixologe <pi...@mailinator.com> on 2008/09/19 13:21:14 UTC

Markup for disabled Link - Proposal (add behavior instead of markup)

Dear Wicket devs,

I propose that by default a disabled link should rather (or also) be marked
using a behavior, instead of adding markup before and after.

A word in advance: I know that I can implement my own version of Link which
adds behavior in case of being disabled, and I know how to do it - this is
not a cry for help, just a proposal, how I think the Link component should
behave to fit most common use cases. The current way simple does not feel
right.

Why do I think so? When creating a template, most people tend to display a
disabled status of an element by appending a css class to its tag, you can
see class="disabled" very often, making colors gray or applying
transparency.
IMHO something like this should not be done by changing the DOM hierarchy of
the element.

Example: a Link with an arrow image (CSS background) - quite common. It is
not (at least as easy as it should be) possible to have another image for a
disabled link with this behavior, since there is nothing like an
if-element-has-child-element-selector in CSS.

Besides (I know it is configurable, but...) : I am not sure why one would
want to [em]phasize something that's disabled ;-)

I would love to see a defaultDisabledLinkBehavior property in future
versions, this would make it a lot easier to style disabled links...

Cheers + best regards :)

--
View this message in context: http://www.nabble.com/Markup-for-disabled-Link---Proposal-%28add-behavior-instead-of-markup%29-tp19570584p19570584.html
Sent from the Wicket - User mailing list archive at Nabble.com.

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org

Re: Markup for disabled Link - Proposal (add behavior instead of markup)

Posted by keithrbennett <ke...@gmail.com>.

I got this working with the following code in the constructor of my Link
subclass:

http://gist.github.com/149344

...and removing the text from the HTML element so it wouldn't display
alongside the image.

I don't know if this is the best way, though.

It would probably make sense for me to refactor this into a class or
something, but it would be even nicer if it were built into Wicket, assuming
it's a common use case to display an image when disabled.

- Keith

keithrbennett wrote:
> 
> Pixologe -
> 
> I am a relative beginner at Wicket, but FWIW your ideas sound reasonable
> and helpful.
> 
> I have a link with an image, and would like to display an alternate image
> if the link is disabled.  I understand that it should be a span element so
> that clicking has no effect.
> 
> Can you, Igor, or anyone, explain to me, or point me to resources, that
> would show me how to do this?
> 
> Thanks,
> Keith Bennett
> 
> 
> 

-- 
View this message in context: http://www.nabble.com/Markup-for-disabled-Link---Proposal-%28add-behavior-instead-of-markup%29-tp19570584p24543114.html
Sent from the Wicket - User mailing list archive at Nabble.com.

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org