You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "zwangsheng (via GitHub)" <gi...@apache.org> on 2023/04/04 10:27:01 UTC
[GitHub] [incubator-celeborn] zwangsheng opened a new pull request, #1410: [CELEBORN-504] Remove useless fields and modify misnamed configurations in `Values.yaml `
zwangsheng opened a new pull request, #1410:
URL: https://github.com/apache/incubator-celeborn/pull/1410
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Streamline the `Values File`.
We will not use this field `celebornVersion` and we have rename some configurations like:
celeborn.worker.fetch.chunk.size => celeborn.shuffle.chunk.size
celeborn.push.io.threads => celeborn.worker.push.io.threads
### Why are the changes needed?
In order not to mislead users and streamline the `Values File`.
### Does this PR introduce _any_ user-facing change?
### How was this patch tested?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] FMX commented on pull request #1410: [CELEBORN-504] Remove useless fields and modify misnamed configurations in `Values.yaml `
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on PR #1410:
URL: https://github.com/apache/incubator-celeborn/pull/1410#issuecomment-1495777491
Looks like there is a misspelling "celeborn.shuffle.chuck.size" ,I think you can correct it.
`
val SHUFFLE_CHUCK_SIZE: ConfigEntry[Long] =
buildConf("celeborn.shuffle.chuck.size")
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1410: [CELEBORN-504] Remove useless fields and modify misnamed configurations in `Values.yaml `
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1410:
URL: https://github.com/apache/incubator-celeborn/pull/1410#issuecomment-1495735050
## [Codecov](https://codecov.io/gh/apache/incubator-celeborn/pull/1410?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1410](https://codecov.io/gh/apache/incubator-celeborn/pull/1410?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bd6f751) into [main](https://codecov.io/gh/apache/incubator-celeborn/commit/a8926403533f819c02014c7f1711b555468f5a72?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a892640) will **decrease** coverage by `0.04%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1410 +/- ##
==========================================
- Coverage 45.04% 44.99% -0.04%
==========================================
Files 164 164
Lines 10404 10404
Branches 1057 1057
==========================================
- Hits 4685 4680 -5
- Misses 5379 5383 +4
- Partials 340 341 +1
```
[see 2 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-celeborn/pull/1410/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] FMX commented on pull request #1410: [CELEBORN-504] Remove useless fields and modify misnamed configurations in `Values.yaml `
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on PR #1410:
URL: https://github.com/apache/incubator-celeborn/pull/1410#issuecomment-1495784597
Looks like angers fix the typo, so there is no need to change the config name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] FMX merged pull request #1410: [CELEBORN-504] Remove useless fields and modify misnamed configurations in `Values.yaml `
Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX merged PR #1410:
URL: https://github.com/apache/incubator-celeborn/pull/1410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org