You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2017/07/05 07:43:47 UTC

Review Request 60646: Modifed handling of parallel test configure flag for documentation.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60646/
-----------------------------------------------------------

Review request for mesos and Till Toenshoff.


Repository: mesos


Description
-------

Modifed handling of parallel test configure flag for documentation.


Diffs
-----

  configure.ac 4d7c4a4679e5c624ee750226d542e0d8c228507a 


Diff: https://reviews.apache.org/r/60646/diff/1/


Testing
-------

configure and build stout with different settings (`--enable-parallel-test-execution`, `--enable-parallel-test-execution=yes`, `--enable-parallel-test-execution=no`, `--disable-parallel-test-execution`), `make check`.


Thanks,

Benjamin Bannier


Re: Review Request 60646: Modified handling of parallel test configure flag for documentation.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60646/#review182491
-----------------------------------------------------------


Ship it!




Ship It!

- Till Toenshoff


On Aug. 7, 2017, 10:30 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60646/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2017, 10:30 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch modifies the handling of the parallel test configure flag
> for documentation purposes. With that we document proper ways to
> handle both default-enabled and -disabled flags without using
> arguments to 'AC_ARG_ENABLE'; the handling of '--disable-werror' is an
> example of a default-enabled flag while
> '--enable-parallel-test-execution' documents a default-disabled flag.
> 
> 
> Diffs
> -----
> 
>   configure.ac 5a6e42c61e6752c3742532502dbc753071b31323 
> 
> 
> Diff: https://reviews.apache.org/r/60646/diff/2/
> 
> 
> Testing
> -------
> 
> configure and build stout with different settings (`--enable-parallel-test-execution`, `--enable-parallel-test-execution=yes`, `--enable-parallel-test-execution=no`, `--disable-parallel-test-execution`), `make check`.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Re: Review Request 60646: Modified handling of parallel test configure flag for documentation.

Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60646/
-----------------------------------------------------------

(Updated Aug. 7, 2017, 12:30 p.m.)


Review request for mesos and Till Toenshoff.


Summary (updated)
-----------------

Modified handling of parallel test configure flag for documentation.


Repository: mesos


Description (updated)
-------

This patch modifies the handling of the parallel test configure flag
for documentation purposes. With that we document proper ways to
handle both default-enabled and -disabled flags without using
arguments to 'AC_ARG_ENABLE'; the handling of '--disable-werror' is an
example of a default-enabled flag while
'--enable-parallel-test-execution' documents a default-disabled flag.


Diffs (updated)
-----

  configure.ac 5a6e42c61e6752c3742532502dbc753071b31323 


Diff: https://reviews.apache.org/r/60646/diff/2/

Changes: https://reviews.apache.org/r/60646/diff/1-2/


Testing
-------

configure and build stout with different settings (`--enable-parallel-test-execution`, `--enable-parallel-test-execution=yes`, `--enable-parallel-test-execution=no`, `--disable-parallel-test-execution`), `make check`.


Thanks,

Benjamin Bannier


Re: Review Request 60646: Modifed handling of parallel test configure flag for documentation.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60646/#review179722
-----------------------------------------------------------



Bad patch!

Reviews applied: [60646, 60000]

Failed command: python support/apply-reviews.py -n -r 60000

Error:
Traceback (most recent call last):
  File "support/apply-reviews.py", line 417, in <module>
    main()
  File "support/apply-reviews.py", line 412, in main
    reviewboard(options)
  File "support/apply-reviews.py", line 402, in reviewboard
    apply_review(options)
  File "support/apply-reviews.py", line 158, in apply_review
    fetch_patch(options)
  File "support/apply-reviews.py", line 215, in fetch_patch
    shell(cmd, options['dry_run'])
UnboundLocalError: local variable 'cmd' referenced before assignment

Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/125/console

- Mesos Reviewbot Windows


On July 5, 2017, 7:43 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60646/
> -----------------------------------------------------------
> 
> (Updated July 5, 2017, 7:43 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Modifed handling of parallel test configure flag for documentation.
> 
> 
> Diffs
> -----
> 
>   configure.ac 4d7c4a4679e5c624ee750226d542e0d8c228507a 
> 
> 
> Diff: https://reviews.apache.org/r/60646/diff/1/
> 
> 
> Testing
> -------
> 
> configure and build stout with different settings (`--enable-parallel-test-execution`, `--enable-parallel-test-execution=yes`, `--enable-parallel-test-execution=no`, `--disable-parallel-test-execution`), `make check`.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>