[jira] [Comment Edited] (HBASE-14588) Stop accessing test resources from within src folder

["Andrew Purtell (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14952026#comment-14952026 ] 

Andrew Purtell edited comment on HBASE-14588 at 10/10/15 8:04 PM:
------------------------------------------------------------------

Edit: Rescinding a +1. The changes look fine but test execution thereafter isn't. I only checked the tests modified by the patch:
{noformat}
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.hadoop.hbase.io.TestReference
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.632 sec <<< FAILURE! - in org.apache.hadoop.hbase.io.TestReference
testParsingWritableReference(org.apache.hadoop.hbase.io.TestReference)  Time elapsed: 0.955 sec  <<< ERROR!
java.io.FileNotFoundException: File /Users/apurtell/src/hbase/hbase-server/target/test-classes/a6a6562b777440fd9c34885428f5cb61.21e75333ada3d5bafb34bb918f29576c does not exist
	at org.apache.hadoop.fs.RawLocalFileSystem.deprecatedGetFileStatus(RawLocalFileSystem.java:606)
	at org.apache.hadoop.fs.RawLocalFileSystem.getFileLinkStatusInternal(RawLocalFileSystem.java:819)
	at org.apache.hadoop.fs.RawLocalFileSystem.getFileStatus(RawLocalFileSystem.java:596)
	at org.apache.hadoop.fs.FilterFileSystem.getFileStatus(FilterFileSystem.java:421)
	at org.apache.hadoop.fs.ChecksumFileSystem$ChecksumFSInputChecker.<init>(ChecksumFileSystem.java:140)
	at org.apache.hadoop.fs.ChecksumFileSystem.open(ChecksumFileSystem.java:341)
	at org.apache.hadoop.fs.FileSystem.open(FileSystem.java:767)
	at org.apache.hadoop.hbase.io.Reference.read(Reference.java:169)
	at org.apache.hadoop.hbase.io.TestReference.testParsingWritableReference(TestReference.java:50)

Running org.apache.hadoop.hbase.regionserver.TestRecoveredEdits
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.124 sec <<< FAILURE! - in org.apache.hadoop.hbase.regionserver.TestRecoveredEdits
testReplayWorksThoughLotsOfFlushing(org.apache.hadoop.hbase.regionserver.TestRecoveredEdits)  Time elapsed: 1.484 sec  <<< ERROR!
java.io.FileNotFoundException: File /Users/apurtell/src/hbase/hbase-server/target/test-classes/0000000000000016310 does not exist
	at org.apache.hadoop.fs.RawLocalFileSystem.deprecatedGetFileStatus(RawLocalFileSystem.java:606)
	at org.apache.hadoop.fs.RawLocalFileSystem.getFileLinkStatusInternal(RawLocalFileSystem.java:819)
	at org.apache.hadoop.fs.RawLocalFileSystem.getFileStatus(RawLocalFileSystem.java:596)
	at org.apache.hadoop.fs.FilterFileSystem.getFileStatus(FilterFileSystem.java:421)
	at org.apache.hadoop.fs.FileUtil.copy(FileUtil.java:337)
	at org.apache.hadoop.fs.FileUtil.copy(FileUtil.java:289)
	at org.apache.hadoop.fs.LocalFileSystem.copyToLocalFile(LocalFileSystem.java:88)
	at org.apache.hadoop.fs.FileSystem.copyToLocalFile(FileSystem.java:1975)
	at org.apache.hadoop.hbase.regionserver.TestRecoveredEdits.testReplayWorksThoughLotsOfFlushing(TestRecoveredEdits.java:124)


Results :

Tests in error: 
  TestReference.testParsingWritableReference:50 » FileNotFound File /Users/apurt...
  TestRecoveredEdits.testReplayWorksThoughLotsOfFlushing:124 » FileNotFound File...

Tests run: 2, Failures: 0, Errors: 2, Skipped: 0
{noformat} 


was (Author: apurtell):
+1

> Stop accessing test resources from within src folder
> ----------------------------------------------------
>
>                 Key: HBASE-14588
>                 URL: https://issues.apache.org/jira/browse/HBASE-14588
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 1.1.0
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: hbase-14588.001.patch, hbase-14588.001.patch
>
>
> A few tests in hbase-server reach into the src/test/data folder to get test resources, which is naughty since tests are supposed to only operate within the target/ folder. It's better to put these into src/test/resources and let them be automatically copied into target/ via the resources plugin, like other test resources.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)