You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by jean-frederic clere <jf...@fujitsu-siemens.com> on 2001/03/30 18:42:04 UTC
[PATCH] apr-iconv
Hi Bill,
I have made some process with apr-iconv (Now it builds and util/iconv runs on
Linux)
It is still not finished (dlopen for example).
Find enclosed the patch to get it running.
I have some questions:
I am not very happy about the following code, any hints to improve it:
+++
+/* To be processed by configure */
+#define ICONV_DEFAULT_PATH "/usr/local/lib/iconv"
+#define EFTYPE -1234
+/* To be processed by configure */
+
+/* apr additions */
+#define issetugid() 0
+/* apr additions */
+++
The default ICONV_DEFAULT_PATH should be a subdirectory of the APR install
directory.
What will be the default install directory of APR?
What to do with issetugid()?
I have removed the iconv_warnx(), there is no logging possible in APR, so only
the "errno" and return code are usefull, is this Ok?
In iconv.c I have put a #ifndef HAVE_ICONV, in case this code gets more
integrated in APR, should this be extented to all other C source files to
prevent names collisions?
Cheers
Jean-frederic