You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2022/02/04 21:41:40 UTC
[GitHub] [groovy] eric-milles opened a new pull request #1681: GROOVY-9866: process discovered sources before units that depend on them
eric-milles opened a new pull request #1681:
URL: https://github.com/apache/groovy/pull/1681
> The discovery mechanism is present in `ClassNodeResolver`/`CompileUnit`/`CompilationUnit` to locate a source, add it and start resolve phase over. The map `sources` in `CompilationUnit` is insertion-ordered, which means the sources will be processed in the order they are discovered. A superclass or superinterface needs to be resolved before its subtype(s).
https://issues.apache.org/jira/browse/GROOVY-9866
To enable this order, process `sources` in reverse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] eric-milles edited a comment on pull request #1681: GROOVY-9866: process discovered sources before units that depend on them
Posted by GitBox <gi...@apache.org>.
eric-milles edited a comment on pull request #1681:
URL: https://github.com/apache/groovy/pull/1681#issuecomment-1030378719
I could do a counting loop from length-1 to 0 instead to save the cost of `reverse`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] eric-milles closed pull request #1681: GROOVY-9866: process discovered sources before units that depend on them
Posted by GitBox <gi...@apache.org>.
eric-milles closed pull request #1681:
URL: https://github.com/apache/groovy/pull/1681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] eric-milles commented on pull request #1681: GROOVY-9866: process discovered sources before units that depend on them
Posted by GitBox <gi...@apache.org>.
eric-milles commented on pull request #1681:
URL: https://github.com/apache/groovy/pull/1681#issuecomment-1030378719
I could do a counting loop from length-1 to 0 instead of reverse to save that cost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] eric-milles commented on pull request #1681: GROOVY-9866: process discovered sources before units that depend on them
Posted by GitBox <gi...@apache.org>.
eric-milles commented on pull request #1681:
URL: https://github.com/apache/groovy/pull/1681#issuecomment-1031910543
I did run into a case of same-package types where the reverse order causes missed inner type resolution. I'll try to construct a test case. At least this commit can serve as an experiment for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org