You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by greghogan <gi...@git.apache.org> on 2017/08/11 18:13:54 UTC

[GitHub] flink issue #4525: [FLINK-7423] Always reuse an instance to get elements fro...

Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/4525
  
    Hi @XuPingyong thanks for submitting this PR. I'm not clear on why the `null` check was added in FLINK-4075 and `ContinuousFileProcessingTest` is not running locally for me. When calling `InputFormat#nextRecord` we can only reuse the returned object. The object passed to `nextRecord` may be reused internally by the `InputFormat` so we cannot simply pass in the same object. It would be better to move `OUT nextElement = serializer.createInstance();` into the outer loop.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---