You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by daserge <gi...@git.apache.org> on 2016/11/15 14:59:46 UTC

[GitHub] cordova-windows pull request #211: CB-11751 'extendedSplashScreen' is undefi...

GitHub user daserge opened a pull request:

    https://github.com/apache/cordova-windows/pull/211

    CB-11751 'extendedSplashScreen' is undefined

    <!--
    Please make sure the checklist boxes are all checked before submitting the PR. The checklist
    is intended as a quick reference, for complete details please see our Contributor Guidelines:
    
    http://cordova.apache.org/contribute/contribute_guidelines.html
    
    Thanks!
    -->
    
    ### What does this PR do?
    [Jira issue](https://issues.apache.org/jira/browse/CB-11751)
    Replaced element implicit calls by id to variable usage.
    Don't fade out if splash element has been removed.
    
    ### What testing has been done on this change?
    Manual and auto tests
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/daserge/cordova-windows CB-11751

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-windows/pull/211.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #211
    
----

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-windows issue #211: CB-11751 'extendedSplashScreen' is undefined

Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:

    https://github.com/apache/cordova-windows/pull/211
  
    ## [Current coverage](https://codecov.io/gh/apache/cordova-windows/pull/211?src=pr) is 74.64% (diff: 100%)
    > Merging [#211](https://codecov.io/gh/apache/cordova-windows/pull/211?src=pr) into [master](https://codecov.io/gh/apache/cordova-windows/branch/master?src=pr) will not change coverage
    
    ```diff
    @@             master       #211   diff @@
    ==========================================
      Files            15         15          
      Lines          2067       2067          
      Methods         390        390          
      Messages          0          0          
      Branches        403        403          
    ==========================================
      Hits           1543       1543          
      Misses          524        524          
      Partials          0          0          
    ```
    
    > Powered by [Codecov](https://codecov.io?src=pr). Last update [541c451...c6e763c](https://codecov.io/gh/apache/cordova-windows/compare/541c451d4665f9db6c8b60d35876f8b5d93bc245...c6e763cbe5cf21d3832af6830060db49167f7d35?src=pr)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-windows pull request #211: CB-11751 'extendedSplashScreen' is undefi...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-windows/pull/211


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org