You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/03/11 15:12:19 UTC
[GitHub] [camel-quarkus] lburgazzoli opened a new pull request #874: Ref
component support
lburgazzoli opened a new pull request #874: Ref component support
URL: https://github.com/apache/camel-quarkus/pull/874
Fixes #818
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request
#874: Ref component support
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #874: Ref component support
URL: https://github.com/apache/camel-quarkus/pull/874#discussion_r391135187
##########
File path: integration-tests/ref/src/main/resources/application.properties
##########
@@ -0,0 +1,16 @@
+## ---------------------------------------------------------------------------
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements. See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License. You may obtain a copy of the License at
+##
+## http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---------------------------------------------------------------------------
Review comment:
pushed to master :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #874:
Ref component support
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #874: Ref component support
URL: https://github.com/apache/camel-quarkus/pull/874#discussion_r391250743
##########
File path: integration-tests/pom.xml
##########
@@ -38,6 +38,8 @@
<sshd.version>2.3.0</sshd.version>
<testcontainers.version>1.12.5</testcontainers.version>
<mock-javamail.version>1.9</mock-javamail.version>
+
+ <quarkus.banner.enabled>false</quarkus.banner.enabled>
Review comment:
Saving a couple of IO bytes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request
#874: Ref component support
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #874: Ref component support
URL: https://github.com/apache/camel-quarkus/pull/874#discussion_r391259282
##########
File path: integration-tests/pom.xml
##########
@@ -38,6 +38,8 @@
<sshd.version>2.3.0</sshd.version>
<testcontainers.version>1.12.5</testcontainers.version>
<mock-javamail.version>1.9</mock-javamail.version>
+
+ <quarkus.banner.enabled>false</quarkus.banner.enabled>
Review comment:
for two reasons:
- it looks ugly at least in my terminal
- some CI may fail if logs are too big
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request
#874: Ref component support
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #874: Ref component support
URL: https://github.com/apache/camel-quarkus/pull/874#discussion_r391055977
##########
File path: integration-tests/ref/src/main/resources/application.properties
##########
@@ -0,0 +1,16 @@
+## ---------------------------------------------------------------------------
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements. See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License. You may obtain a copy of the License at
+##
+## http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---------------------------------------------------------------------------
Review comment:
yeah, should I delete it after merge ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli merged pull request #874: Ref component
support
Posted by GitBox <gi...@apache.org>.
lburgazzoli merged pull request #874: Ref component support
URL: https://github.com/apache/camel-quarkus/pull/874
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull
request #874: Ref component support
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #874: Ref component support
URL: https://github.com/apache/camel-quarkus/pull/874#discussion_r391057602
##########
File path: integration-tests/ref/src/main/resources/application.properties
##########
@@ -0,0 +1,16 @@
+## ---------------------------------------------------------------------------
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements. See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License. You may obtain a copy of the License at
+##
+## http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---------------------------------------------------------------------------
Review comment:
Yep - lets avoid having to do another CI run :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] jamesnetherton commented on a change in pull
request #874: Ref component support
Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on a change in pull request #874: Ref component support
URL: https://github.com/apache/camel-quarkus/pull/874#discussion_r391053717
##########
File path: integration-tests/ref/src/main/resources/application.properties
##########
@@ -0,0 +1,16 @@
+## ---------------------------------------------------------------------------
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements. See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License. You may obtain a copy of the License at
+##
+## http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---------------------------------------------------------------------------
Review comment:
Small nit - presumably we don't need an empty properties file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #874:
Ref component support
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #874: Ref component support
URL: https://github.com/apache/camel-quarkus/pull/874#discussion_r391283661
##########
File path: integration-tests/pom.xml
##########
@@ -38,6 +38,8 @@
<sshd.version>2.3.0</sshd.version>
<testcontainers.version>1.12.5</testcontainers.version>
<mock-javamail.version>1.9</mock-javamail.version>
+
+ <quarkus.banner.enabled>false</quarkus.banner.enabled>
Review comment:
> it looks ugly
We should override it with a good looking ASCII Camel!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services