[GitHub] [ignite] Mmuzaf commented on a change in pull request #7457: IGNITE-12705 SYNC caches are rebalanced in the first place.

[GitBox <gi...@apache.org>]

Mmuzaf commented on a change in pull request #7457: IGNITE-12705 SYNC caches are rebalanced in the first place.
URL: https://github.com/apache/ignite/pull/7457#discussion_r384390560
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/GridCachePartitionExchangeManager.java
 ##########
 @@ -3846,4 +3849,66 @@ void trim() {
             activeObjects.clear();
         }
     }
+
+    /**
+     * Represents a cache rebalance order that takes into account both values: rebalance order itself and rebalance mode.
+     * It is assumed SYNC caches should be rebalanced in the first place.
+     */
+    private static class CacheRebalanceOrder implements Comparable<CacheRebalanceOrder> {
 
 Review comment:
   I think it can be replaced with a comparator which is passing to the constructor for TreeMap. This will require fewer changes and reduce the boilerplate equals\hashcode.
   WDYT? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services