You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Darrel Schneider <ds...@pivotal.io> on 2016/04/13 18:27:30 UTC

Review Request 46151: possible fix for intermittent failure of testTombstones

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46151/
-----------------------------------------------------------

Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.


Bugs: GEODE-561, GEODE-582, GEODE-665, GEODE-840, GEODE-861, and GEODE-926
    https://issues.apache.org/jira/browse/GEODE-561
    https://issues.apache.org/jira/browse/GEODE-582
    https://issues.apache.org/jira/browse/GEODE-665
    https://issues.apache.org/jira/browse/GEODE-840
    https://issues.apache.org/jira/browse/GEODE-861
    https://issues.apache.org/jira/browse/GEODE-926


Repository: geode


Description
-------

Test now disables the GC_MEMORY_THRESHOLD in both jvms before the test begins.
This will prevent the sweeper from expiring a smaller batch of tombstones which could lead to the intermittent failures this test sees.
Also disabled a sleep the test was always doing at the end.


Diffs
-----

  geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java 8f4740c0173e1ea34c814da8b1206de323ce9a9f 

Diff: https://reviews.apache.org/r/46151/diff/


Testing
-------

precheckin


Thanks,

Darrel Schneider


Re: Review Request 46151: possible fix for intermittent failure of testTombstones

Posted by Ken Howe <kh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46151/#review129000
-----------------------------------------------------------


Ship it!




Ship It!

- Ken Howe


On April 13, 2016, 4:27 p.m., Darrel Schneider wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46151/
> -----------------------------------------------------------
> 
> (Updated April 13, 2016, 4:27 p.m.)
> 
> 
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.
> 
> 
> Bugs: GEODE-561, GEODE-582, GEODE-665, GEODE-840, GEODE-861, and GEODE-926
>     https://issues.apache.org/jira/browse/GEODE-561
>     https://issues.apache.org/jira/browse/GEODE-582
>     https://issues.apache.org/jira/browse/GEODE-665
>     https://issues.apache.org/jira/browse/GEODE-840
>     https://issues.apache.org/jira/browse/GEODE-861
>     https://issues.apache.org/jira/browse/GEODE-926
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Test now disables the GC_MEMORY_THRESHOLD in both jvms before the test begins.
> This will prevent the sweeper from expiring a smaller batch of tombstones which could lead to the intermittent failures this test sees.
> Also disabled a sleep the test was always doing at the end.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java 8f4740c0173e1ea34c814da8b1206de323ce9a9f 
> 
> Diff: https://reviews.apache.org/r/46151/diff/
> 
> 
> Testing
> -------
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>


Re: Review Request 46151: possible fix for intermittent failure of testTombstones

Posted by Sai Boorlagadda <sb...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46151/#review128927
-----------------------------------------------------------


Ship it!




Ship It!

- Sai Boorlagadda


On April 13, 2016, 4:27 p.m., Darrel Schneider wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46151/
> -----------------------------------------------------------
> 
> (Updated April 13, 2016, 4:27 p.m.)
> 
> 
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.
> 
> 
> Bugs: GEODE-561, GEODE-582, GEODE-665, GEODE-840, GEODE-861, and GEODE-926
>     https://issues.apache.org/jira/browse/GEODE-561
>     https://issues.apache.org/jira/browse/GEODE-582
>     https://issues.apache.org/jira/browse/GEODE-665
>     https://issues.apache.org/jira/browse/GEODE-840
>     https://issues.apache.org/jira/browse/GEODE-861
>     https://issues.apache.org/jira/browse/GEODE-926
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Test now disables the GC_MEMORY_THRESHOLD in both jvms before the test begins.
> This will prevent the sweeper from expiring a smaller batch of tombstones which could lead to the intermittent failures this test sees.
> Also disabled a sleep the test was always doing at the end.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java 8f4740c0173e1ea34c814da8b1206de323ce9a9f 
> 
> Diff: https://reviews.apache.org/r/46151/diff/
> 
> 
> Testing
> -------
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>


Re: Review Request 46151: possible fix for intermittent failure of testTombstones

Posted by Eric Shu <es...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46151/#review129019
-----------------------------------------------------------


Ship it!




Ship It!

- Eric Shu


On April 13, 2016, 4:27 p.m., Darrel Schneider wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46151/
> -----------------------------------------------------------
> 
> (Updated April 13, 2016, 4:27 p.m.)
> 
> 
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.
> 
> 
> Bugs: GEODE-561, GEODE-582, GEODE-665, GEODE-840, GEODE-861, and GEODE-926
>     https://issues.apache.org/jira/browse/GEODE-561
>     https://issues.apache.org/jira/browse/GEODE-582
>     https://issues.apache.org/jira/browse/GEODE-665
>     https://issues.apache.org/jira/browse/GEODE-840
>     https://issues.apache.org/jira/browse/GEODE-861
>     https://issues.apache.org/jira/browse/GEODE-926
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Test now disables the GC_MEMORY_THRESHOLD in both jvms before the test begins.
> This will prevent the sweeper from expiring a smaller batch of tombstones which could lead to the intermittent failures this test sees.
> Also disabled a sleep the test was always doing at the end.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java 8f4740c0173e1ea34c814da8b1206de323ce9a9f 
> 
> Diff: https://reviews.apache.org/r/46151/diff/
> 
> 
> Testing
> -------
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>


Re: Review Request 46151: possible fix for intermittent failure of testTombstones

Posted by Scott Jewell <sj...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46151/#review128951
-----------------------------------------------------------


Ship it!




Ship It!

- Scott Jewell


On April 13, 2016, 4:27 p.m., Darrel Schneider wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46151/
> -----------------------------------------------------------
> 
> (Updated April 13, 2016, 4:27 p.m.)
> 
> 
> Review request for geode, Eric Shu, Scott Jewell, Ken Howe, and Sai Boorlagadda.
> 
> 
> Bugs: GEODE-561, GEODE-582, GEODE-665, GEODE-840, GEODE-861, and GEODE-926
>     https://issues.apache.org/jira/browse/GEODE-561
>     https://issues.apache.org/jira/browse/GEODE-582
>     https://issues.apache.org/jira/browse/GEODE-665
>     https://issues.apache.org/jira/browse/GEODE-840
>     https://issues.apache.org/jira/browse/GEODE-861
>     https://issues.apache.org/jira/browse/GEODE-926
> 
> 
> Repository: geode
> 
> 
> Description
> -------
> 
> Test now disables the GC_MEMORY_THRESHOLD in both jvms before the test begins.
> This will prevent the sweeper from expiring a smaller batch of tombstones which could lead to the intermittent failures this test sees.
> Also disabled a sleep the test was always doing at the end.
> 
> 
> Diffs
> -----
> 
>   geode-core/src/test/java/com/gemstone/gemfire/cache30/MultiVMRegionTestCase.java 8f4740c0173e1ea34c814da8b1206de323ce9a9f 
> 
> Diff: https://reviews.apache.org/r/46151/diff/
> 
> 
> Testing
> -------
> 
> precheckin
> 
> 
> Thanks,
> 
> Darrel Schneider
> 
>