You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/02/16 20:45:50 UTC
[GitHub] [arrow] seddonm1 opened a new pull request #9507: ARROW-11650: [Rust][DataFusion] Add Postgres License
seddonm1 opened a new pull request #9507:
URL: https://github.com/apache/arrow/pull/9507
DataFusion aims to support the PostgreSQL compatibility. To achieve compatibility parts of the DataFusion code base may have reproduced code and documentation from the PostgreSQL project and needs the license to reflect this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #9507: ARROW-11650: [Rust][DataFusion] Add Postgres License
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #9507:
URL: https://github.com/apache/arrow/pull/9507#issuecomment-781805615
Umm. Generally, I think that we should behave as careful as possible when we reuse codes and documentations of other projects. For example, we should mention that "this code/documentation is derived from PostgreSQL" in each pull request when we add code/documentation derived from PostgreSQL. My concern is that general language approach may lack the behavior. (Note that we don't have a consensus whether the behavior is expected or not yet.)
FYI: I'm not particular about file based approach. We can use suitable approach. For example, there is comment based approach in C++: https://github.com/apache/arrow/blob/dbc77d2e1f19efaa5511f331a3940e4020975394/cpp/cmake_modules/ThirdpartyToolchain.cmake#L694
How about discuss this on arrow-devel@ ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #9507: ARROW-11650: [Rust][DataFusion] Add Postgres License
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #9507:
URL: https://github.com/apache/arrow/pull/9507#issuecomment-783695257
Generally, the general language plus ... approach looks good to me. But the added words concern me.
The approach mentions that `string_expressions.rs` has PostgreSQL licensed codes/documentations but doesn't mention that which codes/documentations use PostgreSQL license explicitly, right?
(`string_expressions.rs` has ASF copyrighted Apache License 2.0 codes/documentations and The PostgreSQL Global Development Group copyrighted PostgreSQL license codes/documentations. But we don't mention which codes/documentations are licensed under PostgreSQL license.)
I'm not sure that it satisfies "provided that the above copyright notice" in PostgreSQL license.
---
I found a guideline when we use third-party works:
https://www.apache.org/legal/src-headers.html#3party
> Treatment of Third-Party Works
> 0. The term "third-party work" refers to a work not submitted directly to the ASF by the copyright owner or owner's agent. This includes parts of a work submitted directly to the ASF for which the submitter is not the copyright owner or owner's agent.
> 1. Do not modify or remove any copyright notices or licenses within third-party works.
> 2. Do ensure that every third-party work includes its associated license, even if that requires adding a copy of the license from the third-party download site into the distribution.
> 3. Do not add the standard Apache License header to the top of third-party source files.
> 4. Minor modifications/additions to third-party source files should typically be licensed under the same terms as the rest of the rest of the third-party source for convenience.
> 5. Major modifications/additions to third-party should be dealt with on a case-by-case basis by the PMC
If we don't mention PostgreSQL derived codes/documentations explicitly, I think that we and users can't associate PostgreSQL derived codes/documentations with The PostgreSQL Global Development Group copyright. I'm not sure that it satisfies 1.
If we choose 4. approach, can we use `arrow/rust/datafusion/src/physical_plan/string_expressions.rs` only for our original implementations that are licensed under Apache License 2.0 and `arrow/rust/datafusion/src/physical_plan/string_postgresql_expressions.rs` (os something) for PostgreSQL derived works that are licensed under PostgreSQL license?
If we choose 5. approach, we should discuss this on dev@.
---
Anyway, I think that we should discuss this on dev@. If we need, ASF will help us with legal concerns.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] seddonm1 commented on pull request #9507: ARROW-11650: [Rust][DataFusion] Add Postgres License
Posted by GitBox <gi...@apache.org>.
seddonm1 commented on pull request #9507:
URL: https://github.com/apache/arrow/pull/9507#issuecomment-782931214
Thanks @kou .
How about we merge this plus we add words like this to the relevant code:
https://github.com/apache/arrow/blob/fa0218277d0171553a35d4696cd48231c274bfdb/rust/datafusion/src/physical_plan/string_expressions.rs#L18
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #9507: ARROW-11650: [Rust][DataFusion] Add Postgres License
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #9507:
URL: https://github.com/apache/arrow/pull/9507#issuecomment-870492570
The datafusion source code have been pulled out to its own repository: https://github.com/apache/arrow-datafusion
If it is still valid than this PR should be reopened there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #9507: ARROW-11650: [Rust][DataFusion] Add Postgres License
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #9507:
URL: https://github.com/apache/arrow/pull/9507#issuecomment-780942264
Could you show existing DataFusion codes and documentations that are derived from PostgreSQL?
Do we want to re-licensing them to ASF copyrighted Apache 2.0 license? Or do we want to reuse them with the original PostgreSQL license?
In C++, we reuse existing codes with the original license. For example, https://github.com/apache/arrow/blob/master/cpp/src/arrow/status.h uses the original BSD-style license.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] seddonm1 commented on pull request #9507: ARROW-11650: [Rust][DataFusion] Add Postgres License
Posted by GitBox <gi...@apache.org>.
seddonm1 commented on pull request #9507:
URL: https://github.com/apache/arrow/pull/9507#issuecomment-781776179
> Thanks.
>
> I think that we should mention which codes and documentations are derived from PostgreSQL. For example, the example documentation showed in [#9243 (comment)](https://github.com/apache/arrow/pull/9243#issuecomment-779486975) should be mentioned.
>
> For example, in C++, https://github.com/apache/arrow/blob/master/cpp/src/arrow/status.h does it in file header.
>
> Can we do it in DataFusion?
My concern is that if we specific file based references for this license it will be very easy to miss when more work is done in the future which may make the project non-compliant. This is why I used general language.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs closed pull request #9507: ARROW-11650: [Rust][DataFusion] Add Postgres License
Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #9507:
URL: https://github.com/apache/arrow/pull/9507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] seddonm1 commented on pull request #9507: ARROW-11650: [Rust][DataFusion] Add Postgres License
Posted by GitBox <gi...@apache.org>.
seddonm1 commented on pull request #9507:
URL: https://github.com/apache/arrow/pull/9507#issuecomment-780952287
Thanks @kou
Here is the original discussion that details what we are referencing: https://github.com/apache/arrow/pull/9243#issuecomment-779486975
Do you have any feedback given this context?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #9507: ARROW-11650: [Rust][DataFusion] Add Postgres License
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #9507:
URL: https://github.com/apache/arrow/pull/9507#issuecomment-781764035
Thanks.
I think that we should mention which codes and documentations are derived from PostgreSQL. For example, the example documentation showed in https://github.com/apache/arrow/pull/9243#issuecomment-779486975 should be mentioned.
For example, in C++, https://github.com/apache/arrow/blob/master/cpp/src/arrow/status.h does it in file header.
Can we do it in DataFusion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9507: ARROW-11650: [Rust][DataFusion] Add Postgres License
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9507:
URL: https://github.com/apache/arrow/pull/9507#issuecomment-780107110
https://issues.apache.org/jira/browse/ARROW-11650
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #9507: ARROW-11650: [Rust][DataFusion] Add Postgres License
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #9507:
URL: https://github.com/apache/arrow/pull/9507#issuecomment-870492570
The datafusion source code have been pulled out to its own repository: https://github.com/apache/arrow-datafusion
If it is still valid than this PR should be reopened there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs closed pull request #9507: ARROW-11650: [Rust][DataFusion] Add Postgres License
Posted by GitBox <gi...@apache.org>.
kszucs closed pull request #9507:
URL: https://github.com/apache/arrow/pull/9507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] seddonm1 commented on pull request #9507: ARROW-11650: [Rust][DataFusion] Add Postgres License
Posted by GitBox <gi...@apache.org>.
seddonm1 commented on pull request #9507:
URL: https://github.com/apache/arrow/pull/9507#issuecomment-783783136
@kou
I have raised a topic on the dev@ list
https://lists.apache.org/thread.html/r263c0d8340c889d83932d7952380438d4c56ea07f96dc63f22c33112%40%3Cdev.arrow.apache.org%3E
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #9507: ARROW-11650: [Rust][DataFusion] Add Postgres License
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #9507:
URL: https://github.com/apache/arrow/pull/9507#issuecomment-783783343
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org