You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/01 04:09:28 UTC
[GitHub] [incubator-superset] rusackas opened a new pull request #10751: chore: removing fsevents dependency
rusackas opened a new pull request #10751:
URL: https://github.com/apache/incubator-superset/pull/10751
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
In a prior PR, I moved this from an Optional Dependency to a Dependency, along with several other package changes, to get CI to start working again. Since this isn't used directly by superset (as far as I can see) I figured it's worth yanking it entirely now to see if CI still passes.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
🤞 CI
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on pull request #10751: chore: removing fsevents dependency
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #10751:
URL: https://github.com/apache/incubator-superset/pull/10751#issuecomment-685890881
Ugh... what a troublesome package! Merging this for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas merged pull request #10751: chore: removing fsevents dependency
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #10751:
URL: https://github.com/apache/incubator-superset/pull/10751
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on pull request #10751: chore: removing fsevents dependency
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #10751:
URL: https://github.com/apache/incubator-superset/pull/10751#issuecomment-685889726
By the way, i think having fsevents as a normal dep isn't the right thing to do, as it breaks non mac environments. I think removing the dep altogether should be fine
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org