You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by jk...@apache.org on 2018/03/03 18:16:37 UTC

thrift git commit: THRIFT-4498: add phpcs back Client: php

Repository: thrift
Updated Branches:
  refs/heads/master 641b139fd -> 8de4bb9c8


THRIFT-4498: add phpcs back
Client: php

This closes #1498


Project: http://git-wip-us.apache.org/repos/asf/thrift/repo
Commit: http://git-wip-us.apache.org/repos/asf/thrift/commit/8de4bb9c
Tree: http://git-wip-us.apache.org/repos/asf/thrift/tree/8de4bb9c
Diff: http://git-wip-us.apache.org/repos/asf/thrift/diff/8de4bb9c

Branch: refs/heads/master
Commit: 8de4bb9c803461811094284486fa5cf402764589
Parents: 641b139
Author: Robert Lu <ro...@gmail.com>
Authored: Thu Feb 22 11:06:07 2018 +0800
Committer: James E. King III <jk...@apache.org>
Committed: Sat Mar 3 13:15:03 2018 -0500

----------------------------------------------------------------------
 build/docker/scripts/sca.sh | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/thrift/blob/8de4bb9c/build/docker/scripts/sca.sh
----------------------------------------------------------------------
diff --git a/build/docker/scripts/sca.sh b/build/docker/scripts/sca.sh
index 886548c..f17f703 100755
--- a/build/docker/scripts/sca.sh
+++ b/build/docker/scripts/sca.sh
@@ -50,9 +50,8 @@ flake8 --ignore=E501,E722 test/crossrunner
 flake8 test/features
 
 # PHP code style
-### causing build failures like https://travis-ci.org/apache/thrift/jobs/341109387
-### composer install --quiet
-### ./vendor/bin/phpcs
+composer install --quiet
+./vendor/bin/phpcs
 
 # TODO etc
 echo FIXMEs: `grep -r FIXME * | wc -l`