[GitHub] [flink] MartijnVisser commented on a change in pull request #18367: [FLINK-25657][Kinesis] Upgrade com.amazonaws:amazon-kinesis-client dependency from 1.14.1 to 1.14.7

[GitBox <gi...@apache.org>]

MartijnVisser commented on a change in pull request #18367:
URL: https://github.com/apache/flink/pull/18367#discussion_r785822628



##########
File path: flink-connectors/flink-connector-kinesis/src/main/resources/META-INF/NOTICE
##########
@@ -6,7 +6,7 @@ The Apache Software Foundation (http://www.apache.org/).
 
 This project bundles the following dependencies under the Apache Software License 2.0. (http://www.apache.org/licenses/LICENSE-2.0.txt) 
 
-- com.amazonaws:amazon-kinesis-client:1.14.1
+- com.amazonaws:amazon-kinesis-client:1.14.7

Review comment:
       Good point @dannycranmer 
   
   When running `mvn compile dependency:tree` on `master`, this is returned for the Kinesis Connector:
   
   ```
   [INFO] +- com.amazonaws:amazon-kinesis-client:jar:1.14.1:compile
   [INFO] |  +- org.apache.commons:commons-lang3:jar:3.3.2:compile
   [INFO] |  \- commons-logging:commons-logging:jar:1.1.3:compile
   ```
   
   When validating it on this branch, it returns:
   
   ```
   [INFO] +- com.amazonaws:amazon-kinesis-client:jar:1.14.7:compile
   [INFO] |  +- org.apache.commons:commons-lang3:jar:3.3.2:compile
   [INFO] |  +- commons-logging:commons-logging:jar:1.1.3:compile
   [INFO] |  \- com.fasterxml.jackson.core:jackson-core:jar:2.13.0:compile
   ```
   
   I'll add `com.fasterxml.jackson.core:jackson-core` to the NOTICE file. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org