You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Mark Montague <ma...@catseye.org> on 2011/04/27 20:03:53 UTC
Patch review request
Could someone with commit access take a look at the following patches?
Neither of these are high priority, but I don't want to let them get too
far out of date.
https://issues.apache.org/bugzilla/show_bug.cgi?id=51077
Fixes two issues with how mod_rewrite handles rules with the [P] flag:
- Makes query string handling for requests destined for mod_proxy_fcgi
and mod_proxy_scgi consistent with how query strings are already handled
for mod_proxy_ajp and mod_proxy_http.
- Makes logic for handling query strings in directory context the same
as in server context.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50880
Prevents mod_proxy_scgi from setting PATH_INFO unless requested, for
better compliance with RFC 3875. This will hopefully be an easy patch
to review, since it was just submitted for consistency with a patch
which was already committed for mod_proxy_fcgi,
https://issues.apache.org/bugzilla/show_bug.cgi?id=50851
Thanks in advance.
--
Mark Montague
mark@catseye.org
mod_rewrite proxy patch review request
Posted by Mark Montague <ma...@catseye.org>.
On April 27, 2011 14:03 , Mark Montague <ma...@catseye.org> wrote:
> Could someone with commit access take a look at the following [...]
>
> https://issues.apache.org/bugzilla/show_bug.cgi?id=51077
>
> Fixes two issues with how mod_rewrite handles rules with the [P] flag:
> - Makes query string handling for requests destined for mod_proxy_fcgi
> and mod_proxy_scgi consistent with how query strings are already
> handled for mod_proxy_ajp and mod_proxy_http.
> - Makes logic for handling query strings in directory context the same
> as in server context.
Also, any advice for how to submit better bug reports and/or make the
report and patch easier for people to review would be appreciated. Thanks!
--
Mark Montague
mark@catseye.org
Re: Patch review request
Posted by Jim Jagielski <ji...@apache.org>.
I'll take a look... thx!
On Apr 27, 2011, at 2:03 PM, Mark Montague wrote:
>
> Could someone with commit access take a look at the following patches? Neither of these are high priority, but I don't want to let them get too far out of date.
>
> https://issues.apache.org/bugzilla/show_bug.cgi?id=51077
>
> Fixes two issues with how mod_rewrite handles rules with the [P] flag:
> - Makes query string handling for requests destined for mod_proxy_fcgi and mod_proxy_scgi consistent with how query strings are already handled for mod_proxy_ajp and mod_proxy_http.
> - Makes logic for handling query strings in directory context the same as in server context.
>
>
> https://issues.apache.org/bugzilla/show_bug.cgi?id=50880
>
> Prevents mod_proxy_scgi from setting PATH_INFO unless requested, for better compliance with RFC 3875. This will hopefully be an easy patch to review, since it was just submitted for consistency with a patch which was already committed for mod_proxy_fcgi, https://issues.apache.org/bugzilla/show_bug.cgi?id=50851
>
>
> Thanks in advance.
>
> --
> Mark Montague
>
> mark@catseye.org