You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/06/17 18:01:58 UTC
[GitHub] [nifi] exceptionfactory opened a new pull request, #6134: NIFI-10137 Change nifi-toolkit-api to use Jersey 2 and Jackson
exceptionfactory opened a new pull request, #6134:
URL: https://github.com/apache/nifi/pull/6134
# Summary
[NIFI-10137](https://issues.apache.org/jira/browse/NIFI-10137) Changes the `nifi-toolkit-api` Swagger Codegen configuration to use Jersey 2 with Jackson instead of OkHttp 2 and Gson with Joda Time for generated classes. Swagger Codegen does not support OkHttp 3 or 4, and OkHttp 2 is deprecated.
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [X] Pull Request based on current revision of the `main` branch
- [X] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [X] Build completed using `mvn clean install -P contrib-check`
- [X] JDK 8
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] NissimShiman commented on a diff in pull request #6134: NIFI-10137 Change nifi-toolkit-api to use Jersey 2 and Jackson
Posted by GitBox <gi...@apache.org>.
NissimShiman commented on code in PR #6134:
URL: https://github.com/apache/nifi/pull/6134#discussion_r912152508
##########
nifi-toolkit/nifi-toolkit-api/pom.xml:
##########
@@ -83,7 +84,7 @@ language governing permissions and limitations under the License. -->
<plugin>
<groupId>io.swagger</groupId>
<artifactId>swagger-codegen-maven-plugin</artifactId>
- <version>2.2.2</version>
+ <version>2.4.27</version>
Review Comment:
It is unclear if moving to swagger 3 would help this issue (i.e. using a more current version of okhttp) as it appears it still uses okhttp 2. See https://github.com/swagger-api/swagger-codegen/blob/3.0.0/samples/client/petstore/java/okhttp-gson/pom.xml#L215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] NissimShiman commented on pull request #6134: NIFI-10137 Change nifi-toolkit-api to use Jersey 2 and Jackson
Posted by GitBox <gi...@apache.org>.
NissimShiman commented on PR #6134:
URL: https://github.com/apache/nifi/pull/6134#issuecomment-1172605337
@exceptionfactory This looks good to me.
LGTM +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6134: NIFI-10137 Change nifi-toolkit-api to use Jersey 2 and Jackson
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on code in PR #6134:
URL: https://github.com/apache/nifi/pull/6134#discussion_r912190782
##########
nifi-toolkit/nifi-toolkit-api/pom.xml:
##########
@@ -83,7 +84,7 @@ language governing permissions and limitations under the License. -->
<plugin>
<groupId>io.swagger</groupId>
<artifactId>swagger-codegen-maven-plugin</artifactId>
- <version>2.2.2</version>
+ <version>2.4.27</version>
Review Comment:
Thanks for the note @NissimShiman! Moving to Swagger 3 is a good goal, but as you noted, it appears that the codegen plugin still depends on an old version of OkHttp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] NissimShiman commented on a diff in pull request #6134: NIFI-10137 Change nifi-toolkit-api to use Jersey 2 and Jackson
Posted by GitBox <gi...@apache.org>.
NissimShiman commented on code in PR #6134:
URL: https://github.com/apache/nifi/pull/6134#discussion_r912152508
##########
nifi-toolkit/nifi-toolkit-api/pom.xml:
##########
@@ -83,7 +84,7 @@ language governing permissions and limitations under the License. -->
<plugin>
<groupId>io.swagger</groupId>
<artifactId>swagger-codegen-maven-plugin</artifactId>
- <version>2.2.2</version>
+ <version>2.4.27</version>
Review Comment:
It is unclear if moving to swagger 3 would help this issue (i.e. using a more current version of okhttp) as it appears it still uses okhttp 2. See https://github.com/swagger-api/swagger-codegen/blob/3.0.0/samples/client/petstore/java/okhttp-gson/pom.xml#L215
but
maybe there can be a follow up ticket at some point to go to swagger codegen 3 as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] asfgit closed pull request #6134: NIFI-10137 Change nifi-toolkit-api to use Jersey 2 and Jackson
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #6134: NIFI-10137 Change nifi-toolkit-api to use Jersey 2 and Jackson
URL: https://github.com/apache/nifi/pull/6134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #6134: NIFI-10137 Change nifi-toolkit-api to use Jersey 2 and Jackson
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on PR #6134:
URL: https://github.com/apache/nifi/pull/6134#issuecomment-1172625430
Thanks for the review and feedback @NissimShiman!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org