You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/27 03:58:56 UTC
[GitHub] [beam] ibzib commented on a change in pull request #11797: [BEAM-10065] Fix beam release guide template
ibzib commented on a change in pull request #11797:
URL: https://github.com/apache/beam/pull/11797#discussion_r430480420
##########
File path: website/www/site/static/js/language-switch.js
##########
@@ -113,7 +113,7 @@ $(document).ready(function() {
}
// Swapping visibility of code blocks.
- $(this.selector).hide();
+ $(this.selector).not(".language-md").hide();
Review comment:
Why is this change needed?
##########
File path: website/www/site/static/js/language-switch.js
##########
@@ -113,7 +113,7 @@ $(document).ready(function() {
}
// Swapping visibility of code blocks.
- $(this.selector).hide();
+ $(this.selector).not(".language-md").hide();
Review comment:
This is a bigger problem than just markdown. Every code block that specifies a language that is not toggled on will be hidden. I filed BEAM-10092.
For now, since syntax highlighting is not important here, please remove the `md` and we can merge the rest of your changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org