You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Likitha Shetty <li...@citrix.com> on 2012/07/30 10:49:54 UTC
Review Request: CS-14770. ec2-run-instances and ec2-describe-instances don't
return keypair information. Component: AWSAPI.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6203/
-----------------------------------------------------------
Review request for cloudstack and Prachi Damle.
Description
-------
In CloudStack, changing the api response of deployVirtualMachine and listVirtualMachine to include ssh keypair information.
This addresses bug CS-14770.
Diffs
-----
api/src/com/cloud/api/response/UserVmResponse.java 652e026
awsapi/src/com/cloud/bridge/service/EC2SoapServiceImpl.java 38f80c8
awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java 1363d0d
awsapi/src/com/cloud/bridge/service/core/ec2/EC2Instance.java 6e2d696
awsapi/src/com/cloud/stack/models/CloudStackUserVm.java e1db2d9
server/src/com/cloud/api/ApiDBUtils.java cfc71de
server/src/com/cloud/api/ApiResponseHelper.java 433d263
server/src/com/cloud/user/dao/SSHKeyPairDao.java 84295da
server/src/com/cloud/user/dao/SSHKeyPairDaoImpl.java 58999e0
server/src/com/cloud/vm/dao/UserVmData.java 4a0d10d
server/src/com/cloud/vm/dao/UserVmDetailsDaoImpl.java 6975c8c
Diff: https://reviews.apache.org/r/6203/diff/
Testing
-------
Verified that the output of ec2-run-instances and ec2-describe-instances contained the keypair-name that was used to launch the virtual-machine.
Thanks,
Likitha Shetty
Re: Review Request: CS-14770. ec2-run-instances and ec2-describe-instances
don't return keypair information. Component: AWSAPI.
Posted by Prachi Damle <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6203/#review10820
-----------------------------------------------------------
Ship it!
- Prachi Damle
On Aug. 16, 2012, 8:53 a.m., Likitha Shetty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6203/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2012, 8:53 a.m.)
>
>
> Review request for cloudstack and Prachi Damle.
>
>
> Description
> -------
>
> In CloudStack, changing the api response of deployVirtualMachine and listVirtualMachine to include ssh keypair information.
>
>
> This addresses bug CS-14770.
>
>
> Diffs
> -----
>
> api/src/com/cloud/api/response/UserVmResponse.java 652e026
> awsapi/src/com/cloud/bridge/service/EC2SoapServiceImpl.java 38f80c8
> awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java 1363d0d
> awsapi/src/com/cloud/bridge/service/core/ec2/EC2Instance.java 6e2d696
> awsapi/src/com/cloud/stack/models/CloudStackUserVm.java e1db2d9
> server/src/com/cloud/api/ApiDBUtils.java e1e8865
> server/src/com/cloud/api/ApiResponseHelper.java 0340a94
> server/src/com/cloud/user/dao/SSHKeyPairDao.java 84295da
> server/src/com/cloud/user/dao/SSHKeyPairDaoImpl.java 58999e0
> server/src/com/cloud/vm/dao/UserVmData.java 4a0d10d
> server/src/com/cloud/vm/dao/UserVmDetailsDaoImpl.java 6975c8c
>
> Diff: https://reviews.apache.org/r/6203/diff/
>
>
> Testing
> -------
>
> Verified that the output of ec2-run-instances and ec2-describe-instances contained the keypair-name that was used to launch the virtual-machine.
>
>
> Thanks,
>
> Likitha Shetty
>
>
Re: Review Request: CS-14770. ec2-run-instances and ec2-describe-instances
don't return keypair information. Component: AWSAPI.
Posted by Likitha Shetty <li...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6203/
-----------------------------------------------------------
(Updated Aug. 16, 2012, 8:53 a.m.)
Review request for cloudstack and Prachi Damle.
Description
-------
In CloudStack, changing the api response of deployVirtualMachine and listVirtualMachine to include ssh keypair information.
This addresses bug CS-14770.
Diffs (updated)
-----
api/src/com/cloud/api/response/UserVmResponse.java 652e026
awsapi/src/com/cloud/bridge/service/EC2SoapServiceImpl.java 38f80c8
awsapi/src/com/cloud/bridge/service/core/ec2/EC2Engine.java 1363d0d
awsapi/src/com/cloud/bridge/service/core/ec2/EC2Instance.java 6e2d696
awsapi/src/com/cloud/stack/models/CloudStackUserVm.java e1db2d9
server/src/com/cloud/api/ApiDBUtils.java e1e8865
server/src/com/cloud/api/ApiResponseHelper.java 0340a94
server/src/com/cloud/user/dao/SSHKeyPairDao.java 84295da
server/src/com/cloud/user/dao/SSHKeyPairDaoImpl.java 58999e0
server/src/com/cloud/vm/dao/UserVmData.java 4a0d10d
server/src/com/cloud/vm/dao/UserVmDetailsDaoImpl.java 6975c8c
Diff: https://reviews.apache.org/r/6203/diff/
Testing
-------
Verified that the output of ec2-run-instances and ec2-describe-instances contained the keypair-name that was used to launch the virtual-machine.
Thanks,
Likitha Shetty