You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by Vladimir Sitnikov <si...@gmail.com> on 2020/10/06 21:23:27 UTC
CALCITE-2269 Enable Error-Prone checking
Hi,
I've added Error-Prone verification to GitHub Actions CI in
https://github.com/apache/calcite/pull/2182
I'm inclined to merge the PR soon, as the topic has already been discussed
in CALCITE-2269 2 years ago.
Sorry for the inconvenience and the merge conflicts it causes if any.
Error-Prone would fail the build when it detects violations. The test code
is not verified.
The check takes 4-5 minutes.
One can execute the verification locally via ./gradlew -PenableErrorpone
-Pwerror=false classes
Calcite uses Werror by default to fail on javac warnings, so -Pwerror=false
allows Error-Prone to display all the warnings.
----
Most of the changes (35 commits in total, +5,779 −5,015) are for the
following checks:
Add missing @Override annotations
745 files changed, 4490 insertions(+), 4456 deletions(-)
Add missing default branches to switch statement
98 files changed, 691 insertions(+), 55 deletions(-)
Remove unused fields, methods, and variables
79 files changed, 104 insertions(+), 149 deletions(-)
Vladimir
Re: CALCITE-2269 Enable Error-Prone checking
Posted by Julian Hyde <jh...@apache.org>.
Fine, but please create a new JIRA case.
https://issues.apache.org/jira/browse/CALCITE-2269 was fixed and
closed 18 months and should have remained closed.
On Tue, Oct 6, 2020 at 2:23 PM Vladimir Sitnikov
<si...@gmail.com> wrote:
>
> Hi,
>
> I've added Error-Prone verification to GitHub Actions CI in
> https://github.com/apache/calcite/pull/2182
> I'm inclined to merge the PR soon, as the topic has already been discussed
> in CALCITE-2269 2 years ago.
>
> Sorry for the inconvenience and the merge conflicts it causes if any.
>
> Error-Prone would fail the build when it detects violations. The test code
> is not verified.
> The check takes 4-5 minutes.
> One can execute the verification locally via ./gradlew -PenableErrorpone
> -Pwerror=false classes
> Calcite uses Werror by default to fail on javac warnings, so -Pwerror=false
> allows Error-Prone to display all the warnings.
>
> ----
>
> Most of the changes (35 commits in total, +5,779 −5,015) are for the
> following checks:
>
> Add missing @Override annotations
> 745 files changed, 4490 insertions(+), 4456 deletions(-)
>
> Add missing default branches to switch statement
> 98 files changed, 691 insertions(+), 55 deletions(-)
>
> Remove unused fields, methods, and variables
> 79 files changed, 104 insertions(+), 149 deletions(-)
>
> Vladimir