[royale-asjs] branch develop updated: Make sure measurement of height does not leave state of dom element in limbo

[yi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

yishayw pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new a83f4e9  Make sure measurement of height does not leave state of dom element in limbo
a83f4e9 is described below

commit a83f4e9d33c92a4f0ff54eae0fa2a343d9afa5d4
Author: Yishay Weiss <yi...@hotmail.com>
AuthorDate: Wed Dec 9 13:50:47 2020 +0000

    Make sure measurement of height does not leave state of dom element in limbo
---
 frameworks/projects/MXRoyale/src/main/royale/mx/core/UIComponent.as | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/frameworks/projects/MXRoyale/src/main/royale/mx/core/UIComponent.as b/frameworks/projects/MXRoyale/src/main/royale/mx/core/UIComponent.as
index f924fcc..96de76c 100644
--- a/frameworks/projects/MXRoyale/src/main/royale/mx/core/UIComponent.as
+++ b/frameworks/projects/MXRoyale/src/main/royale/mx/core/UIComponent.as
@@ -2397,10 +2397,10 @@ COMPILE::JS
                 oldTop = this.positioner.style.top;
                 oldBottom = this.positioner.style.bottom;
                 oldHeight = this.positioner.style.height;
-                if (oldHeight.length)
-                    this.positioner.style.height = "";
                 if (oldTop.length && oldBottom.length) // if both are set, this also dictates height
                     return 0; //this.positioner.style.top = "";
+                if (oldHeight.length)
+                    this.positioner.style.height = "";
                 var mh:Number = this.positioner.offsetHeight;
                 if (mh == 0 && numChildren > 0)
                 {