[GitHub] [incubator-teaclave] dingelish commented on a change in pull request #608: update WAMR

[GitBox <gi...@apache.org>]

dingelish commented on a change in pull request #608:
URL: https://github.com/apache/incubator-teaclave/pull/608#discussion_r798854144



##########
File path: executor/src/wamr.rs
##########
@@ -100,6 +101,19 @@ extern "C" {
 #[derive(Default)]
 pub struct WAMicroRuntime;
 
+macro_rules! early_terminate {
+    ($cond:expr, $msg:expr, $func:block) => {
+        if !($cond) {
+            reset_thread_context()?;
+            #[allow(unused_unsafe)]

Review comment:
       consider removal. after this pr, `wasm_runtime_***` will looks like "safe" if it's wrapped in early_terminate




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org