[GitHub] [superset] betodealmeida commented on a diff in pull request #25303: feat: generic marshmallow error component

["betodealmeida (via GitHub)" <gi...@apache.org>]

betodealmeida commented on code in PR #25303:
URL: https://github.com/apache/superset/pull/25303#discussion_r1326518654


##########
superset/datasets/api.py:
##########
@@ -330,7 +330,6 @@ def post(self) -> Response:
 
     @expose("/<pk>", methods=("PUT",))
     @protect()
-    @safe

Review Comment:
   It's from FAB, it catches unhandled exceptions and returns a 500 JSON payload. The problem is that the payload is not [SIP-40](https://github.com/apache/superset/issues/9194) compatible. When we remove the decorator [Flask will catch any exceptions and return a SIP-40 compatible JSON payload](https://github.com/apache/superset/blob/ec6191023263ac5f8292dd37f037805c3196e029/superset/views/base.py#L519-L535), so it's not needed at all.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org