You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/03/08 05:58:00 UTC

[jira] [Commented] (KAFKA-9656) TxnOffsetCommit should not return COORDINATOR_LOADING error for old request versions

    [ https://issues.apache.org/jira/browse/KAFKA-9656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17054299#comment-17054299 ] 

ASF GitHub Bot commented on KAFKA-9656:
---------------------------------------

abbccdda commented on pull request #8253: KAFKA-9656: Return COORDINATOR_NOT_AVAILABLE for older producer clients
URL: https://github.com/apache/kafka/pull/8253
 
 
   Txn commit has a bug for lower versions where it would treat `COORDINATOR_LOAD_IN_PROGRESS` as fatal. This PR fixes the handling of older client to return 
   `COORDINATOR_NOT_AVAILABLE` so that it won't crash upon doing txn commit. 
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> TxnOffsetCommit should not return COORDINATOR_LOADING error for old request versions
> ------------------------------------------------------------------------------------
>
>                 Key: KAFKA-9656
>                 URL: https://issues.apache.org/jira/browse/KAFKA-9656
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Jason Gustafson
>            Assignee: Boyang Chen
>            Priority: Major
>
> In KAFKA-7296, we fixed a bug which causes the producer to enter a fatal state when the COORDINATOR_LOADING_IN_PROGRESS error is received. The impact of this bug in streams was that the application would crash. Generally we want users to upgrade to a later client version, but in some cases, this takes a long time. I am suggesting here that we revert the behavior change on the broker for older versions of TxnOffsetCommit. For versions older than 2 (which was introduced in 2.3), rather than returning COORDINATOR_LOADING_IN_PROGRESS, we can return COORDINATOR_NOT_AVAILABLE.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)