You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2019/04/26 18:09:39 UTC
svn commit: r1858220 - in /ofbiz:
ofbiz-framework/trunk/applications/product/groovyScripts/facility/shipment/
ofbiz-plugins/trunk/pricat/src/main/java/org/apache/ofbiz/pricat/util/
Author: jleroux
Date: Fri Apr 26 18:09:39 2019
New Revision: 1858220
URL: http://svn.apache.org/viewvc?rev=1858220&view=rev
Log:
Improved: Java code contains unnecessary semicolons
(OFBIZ-10936)
Loosely related: Groovy code don't even needs them :)
Thanks: Mathieu for creating the Jira
Modified:
ofbiz/ofbiz-framework/trunk/applications/product/groovyScripts/facility/shipment/PackOrder.groovy
ofbiz/ofbiz-framework/trunk/applications/product/groovyScripts/facility/shipment/WeightPackage.groovy
ofbiz/ofbiz-plugins/trunk/pricat/src/main/java/org/apache/ofbiz/pricat/util/OFBizPricatUtil.java
Modified: ofbiz/ofbiz-framework/trunk/applications/product/groovyScripts/facility/shipment/PackOrder.groovy
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/groovyScripts/facility/shipment/PackOrder.groovy?rev=1858220&r1=1858219&r2=1858220&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/product/groovyScripts/facility/shipment/PackOrder.groovy (original)
+++ ofbiz/ofbiz-framework/trunk/applications/product/groovyScripts/facility/shipment/PackOrder.groovy Fri Apr 26 18:09:39 2019
@@ -180,5 +180,5 @@ if (facility) {
if (!defaultWeightUomId) {
defaultWeightUomId = EntityUtilProperties.getPropertyValue("shipment", "shipment.default.weight.uom", "WT_kg", delegator)
}
-context.defaultWeightUom = from("Uom").where("uomId", defaultWeightUomId).cache().queryOne();;
+context.defaultWeightUom = from("Uom").where("uomId", defaultWeightUomId).cache().queryOne()
context.defaultWeightUomId = defaultWeightUomId
Modified: ofbiz/ofbiz-framework/trunk/applications/product/groovyScripts/facility/shipment/WeightPackage.groovy
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/product/groovyScripts/facility/shipment/WeightPackage.groovy?rev=1858220&r1=1858219&r2=1858220&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/product/groovyScripts/facility/shipment/WeightPackage.groovy (original)
+++ ofbiz/ofbiz-framework/trunk/applications/product/groovyScripts/facility/shipment/WeightPackage.groovy Fri Apr 26 18:09:39 2019
@@ -192,7 +192,7 @@ if (facility) {
if (!defaultDimensionUomId) {
defaultDimensionUomId = EntityUtilProperties.getPropertyValue("shipment", "shipment.default.dimension.uom", "LEN_in", delegator)
}
-context.defaultDimensionUom = from("Uom").where("uomId", defaultDimensionUomId).cache().queryOne();;
+context.defaultDimensionUom = from("Uom").where("uomId", defaultDimensionUomId).cache().queryOne()
context.defaultDimensionUomId = defaultDimensionUomId
defaultWeightUomId = null
@@ -203,5 +203,5 @@ if (!defaultWeightUomId) {
defaultWeightUomId = EntityUtilProperties.getPropertyValue("shipment", "shipment.default.weight.uom", "WT_kg", delegator)
}
-context.defaultWeightUom = from("Uom").where("uomId", defaultWeightUomId).cache().queryOne();;
+context.defaultWeightUom = from("Uom").where("uomId", defaultWeightUomId).cache().queryOne()
context.defaultWeightUomId = defaultWeightUomId
Modified: ofbiz/ofbiz-plugins/trunk/pricat/src/main/java/org/apache/ofbiz/pricat/util/OFBizPricatUtil.java
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-plugins/trunk/pricat/src/main/java/org/apache/ofbiz/pricat/util/OFBizPricatUtil.java?rev=1858220&r1=1858219&r2=1858220&view=diff
==============================================================================
--- ofbiz/ofbiz-plugins/trunk/pricat/src/main/java/org/apache/ofbiz/pricat/util/OFBizPricatUtil.java (original)
+++ ofbiz/ofbiz-plugins/trunk/pricat/src/main/java/org/apache/ofbiz/pricat/util/OFBizPricatUtil.java Fri Apr 26 18:09:39 2019
@@ -66,7 +66,7 @@ public final class OFBizPricatUtil {
CTShape ctshape = (CTShape) FindCommentShapeMethod.invoke(vml, cell.getRow(), cell.getCol());
ctshape.setType("#_x0000_t202");
} catch (IllegalAccessException | IllegalArgumentException | InvocationTargetException e) {
- Debug.logError(e, module);;
+ Debug.logError(e, module)
}
}
}
@@ -81,7 +81,7 @@ public final class OFBizPricatUtil {
CTShape ctshape = (CTShape) FindCommentShapeMethod.invoke(vml, rowNum, colNum);
ctshape.setType("#_x0000_t202");
} catch (IllegalAccessException | IllegalArgumentException | InvocationTargetException e) {
- Debug.logError(e, module);;
+ Debug.logError(e, module)
}
}
}