[GitHub] [airflow] o-nikolas commented on pull request #28710: Apply "unify bucket and key" before "provide bucket"

[GitBox <gi...@apache.org>]

o-nikolas commented on PR #28710:
URL: https://github.com/apache/airflow/pull/28710#issuecomment-1371533722

   > ok @o-nikolas and @feluelle i have updated these tests to move the "tokens" to individual params. it's not quite "putting the test values in the tuple", which, if i understood correctly, is what yall were thinking of (and what i more or less strenuously object to doing, myself anyway)
   
   Thanks @dstandish! And this was actually exactly what I was intending in the previous CR, apologies if we miscommunicated there :pray:
   I only left one comment for a way to optimize it further (using booleans as the param values instead of strings for everything but `expected`). Feel free to do so or not :smiley:  
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org