[GitHub] [helix] brentwritescode edited a comment on issue #1319: Documentation states build requirements as JDK 1.8+, Maven 3.5.0+, but Helix fails to build for Java 11+

[GitBox <gi...@apache.org>]

brentwritescode edited a comment on issue #1319:
URL: https://github.com/apache/helix/issues/1319#issuecomment-685007677


   Great, thank you for the details.
   
   As a side note (if this derails this discussion, feel free to ignore) have you considered creating a `contributors.md` or `contributing.md` file as recommended by https://docs.github.com/en/github/building-a-strong-community/setting-guidelines-for-repository-contributors somewhere in the root of the project?  That's at least where I've been conditioned to look for that stuff if it's not mentioned in the README.md (e.g. https://github.com/apache/kafka/blob/trunk/CONTRIBUTING.md).
   
   UPDATE: I just discovered these links, ignore the previous comment. :-)
   
   https://github.com/apache/helix/wiki/Pull-Request-Guidelines
   https://github.com/apache/helix/wiki/Pull-Request-Description-Template
   https://github.com/apache/helix/wiki/Pull-Request-Merge-Steps
   https://github.com/apache/helix/wiki/Helix-Code-Style-in-Intellij-IDE
   
   My apologies!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org