You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2023/06/08 11:56:48 UTC
[GitHub] [incubator-celeborn] pan3793 opened a new pull request, #1563: [CELEBORN-653][TEST] Fix invalid configuration setting in SparkTestBase
pan3793 opened a new pull request, #1563:
URL: https://github.com/apache/incubator-celeborn/pull/1563
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
Dot is missing after `spark`
### Why are the changes needed?
Correct the configuration key.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass GA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] codecov[bot] commented on pull request #1563: [CELEBORN-653][TEST] Fix invalid configuration key in SparkTestBase
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #1563:
URL: https://github.com/apache/incubator-celeborn/pull/1563#issuecomment-1582466457
## [Codecov](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1563](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1563?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (08ca1ac) into [main](https://app.codecov.io/gh/apache/incubator-celeborn/commit/0c869ac9a0efcb92c6a07d0d0f15bf3274a86d2f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0c869ac) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #1563 +/- ##
==========================================
- Coverage 45.41% 45.38% -0.03%
==========================================
Files 158 158
Lines 9823 9823
Branches 968 968
==========================================
- Hits 4460 4457 -3
- Misses 5062 5065 +3
Partials 301 301
```
[see 1 file with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-celeborn/pull/1563/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] zwangsheng commented on a diff in pull request #1563: [CELEBORN-653][TEST] Fix invalid configuration key in SparkTestBase
Posted by "zwangsheng (via GitHub)" <gi...@apache.org>.
zwangsheng commented on code in PR #1563:
URL: https://github.com/apache/incubator-celeborn/pull/1563#discussion_r1223753309
##########
tests/spark-it/src/test/scala/org/apache/celeborn/tests/spark/SparkTestBase.scala:
##########
@@ -45,20 +45,16 @@ trait SparkTestBase extends AnyFunSuite
shutdownMiniCluster()
}
- def updateSparkConf(sparkConf: SparkConf, sort: Boolean): SparkConf = {
+ def updateSparkConf(sparkConf: SparkConf, shuffleWriteMode: String): SparkConf = {
Review Comment:
How about using `ShuffleMode` enum for args type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on pull request #1563: [CELEBORN-653][TEST] Fix invalid configuration key in SparkTestBase
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #1563:
URL: https://github.com/apache/incubator-celeborn/pull/1563#issuecomment-1583856156
Merged to main/0.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1563: [CELEBORN-653][TEST] Fix invalid configuration key in SparkTestBase
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1563:
URL: https://github.com/apache/incubator-celeborn/pull/1563#discussion_r1222941111
##########
tests/spark-it/src/test/scala/org/apache/celeborn/tests/spark/SparkTestBase.scala:
##########
@@ -45,20 +45,16 @@ trait SparkTestBase extends AnyFunSuite
shutdownMiniCluster()
}
- def updateSparkConf(sparkConf: SparkConf, sort: Boolean): SparkConf = {
+ def updateSparkConf(sparkConf: SparkConf, shuffleWriteMode: String): SparkConf = {
sparkConf.set("spark.serializer", "org.apache.spark.serializer.KryoSerializer")
sparkConf.set("spark.shuffle.manager", "org.apache.spark.shuffle.celeborn.RssShuffleManager")
sparkConf.set("spark.shuffle.useOldFetchProtocol", "true")
sparkConf.set("spark.sql.adaptive.enabled", "false")
sparkConf.set("spark.shuffle.service.enabled", "false")
sparkConf.set("spark.sql.adaptive.skewJoin.enabled", "false")
sparkConf.set("spark.sql.adaptive.localShuffleReader.enabled", "false")
- sparkConf.set(
- s"spark${CelebornConf.MASTER_ENDPOINTS.key}",
Review Comment:
@AngersZhuuuu here is the core change, others are simple code adjustments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1563: [CELEBORN-653][TEST] Fix invalid configuration setting in SparkTestBase
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1563:
URL: https://github.com/apache/incubator-celeborn/pull/1563#discussion_r1222941111
##########
tests/spark-it/src/test/scala/org/apache/celeborn/tests/spark/SparkTestBase.scala:
##########
@@ -45,20 +45,16 @@ trait SparkTestBase extends AnyFunSuite
shutdownMiniCluster()
}
- def updateSparkConf(sparkConf: SparkConf, sort: Boolean): SparkConf = {
+ def updateSparkConf(sparkConf: SparkConf, shuffleWriteMode: String): SparkConf = {
sparkConf.set("spark.serializer", "org.apache.spark.serializer.KryoSerializer")
sparkConf.set("spark.shuffle.manager", "org.apache.spark.shuffle.celeborn.RssShuffleManager")
sparkConf.set("spark.shuffle.useOldFetchProtocol", "true")
sparkConf.set("spark.sql.adaptive.enabled", "false")
sparkConf.set("spark.shuffle.service.enabled", "false")
sparkConf.set("spark.sql.adaptive.skewJoin.enabled", "false")
sparkConf.set("spark.sql.adaptive.localShuffleReader.enabled", "false")
- sparkConf.set(
- s"spark${CelebornConf.MASTER_ENDPOINTS.key}",
Review Comment:
@AngersZhuuuu here is the core change, the left is simple code adjustments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 closed pull request #1563: [CELEBORN-653][TEST] Fix invalid configuration key in SparkTestBase
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #1563: [CELEBORN-653][TEST] Fix invalid configuration key in SparkTestBase
URL: https://github.com/apache/incubator-celeborn/pull/1563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1563: [CELEBORN-653][TEST] Fix invalid configuration key in SparkTestBase
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #1563:
URL: https://github.com/apache/incubator-celeborn/pull/1563#discussion_r1223758724
##########
tests/spark-it/src/test/scala/org/apache/celeborn/tests/spark/SparkTestBase.scala:
##########
@@ -45,20 +45,16 @@ trait SparkTestBase extends AnyFunSuite
shutdownMiniCluster()
}
- def updateSparkConf(sparkConf: SparkConf, sort: Boolean): SparkConf = {
+ def updateSparkConf(sparkConf: SparkConf, shuffleWriteMode: String): SparkConf = {
Review Comment:
Thanks, changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org